[GitHub] [incubator-inlong] healchow commented on a change in pull request #2740: [INLONG-2677][Manager] Get MQ cluster from database, remove local file configuration dependency

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #2740:
URL: https://github.com/apache/incubator-inlong/pull/2740#discussion_r815274853



##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/thirdparty/mq/TubeMqOptService.java
##########
@@ -56,19 +57,21 @@ public String createNewTopic(AddTubeMqTopicRequest request) {
                 throw new Exception("topic cannot be empty");
             }
             AddTubeMqTopicRequest.AddTopicTasksBean addTopicTasksBean = request.getAddTopicTasks().get(0);
+            String clusterIdStr = commonOperateService.getSpecifiedParam(Constant.CLUSTER_TUBE_CLUSTER_ID);
+            int clusterId = Integer.valueOf(clusterIdStr);

Review comment:
       Replace with `Integer.parseInt`.

##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/thirdparty/sort/CreateSortConfigListener.java
##########
@@ -90,14 +94,14 @@ public ListenerResult listen(WorkflowContext context) throws Exception {
         }
 
         Map<String, DataFlowInfo> dataFlowInfoMap = streamBriefResponses.stream().map(streamBriefResponse -> {
-                            DataFlowInfo flowInfo = createDataFlow(streamBriefResponse, groupRequest);

Review comment:
       Do not change those code formate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org