[jira] [Resolved] (AIRFLOW-5489) bash_senor: Remove unneeded assignment of variable

["Kaxil Naik (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kaxil Naik resolved AIRFLOW-5489.
---------------------------------
    Fix Version/s: 1.10.6
       Resolution: Fixed

> bash_senor: Remove unneeded assignment of variable
> --------------------------------------------------
>
>                 Key: AIRFLOW-5489
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5489
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.6
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: ccoss2019, newbie
>             Fix For: 1.10.6
>
>
> Note: This ticket's being created to facilitate a new contributor's workshop for Airflow. After the workshop has completed, I'll mark these all available for anyone that might like to take them on.
> The `line` variable is assigned to `''` but then immediately reassigned in the loop.  This first assignment should be deleted.
> airflow/contrib/sensors/bash_sensor.py:83
> {code:java}
> line = ''
> for line in iter(sp.stdout.readline, b''):
>     line = line.decode(self.output_encoding).strip()
>     self.log.info(line)
> sp.wait()
> self.log.info("Command exited with return code %s", sp.returncode) {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)