[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #601: feat: implement schema API

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #601:
URL: https://github.com/apache/apisix-ingress-controller/pull/601#discussion_r673596992



##########
File path: pkg/apisix/schema.go
##########
@@ -0,0 +1,91 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package apisix
+
+import (
+	"context"
+
+	"github.com/apache/apisix-ingress-controller/pkg/apisix/cache"

Review comment:
       Please categorize the imports, one for 3rd parties, and one for packages in current module.

##########
File path: pkg/apisix/plugin.go
##########
@@ -0,0 +1,49 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package apisix
+
+import (
+	"context"
+	"github.com/apache/apisix-ingress-controller/pkg/log"
+	"go.uber.org/zap"
+)
+
+type pluginClient struct {
+	url     string
+	cluster *cluster
+}
+
+func newPluginClient(c *cluster) Plugin {
+	return &pluginClient{
+		url:     c.baseURL + "/plugins",
+		cluster: c,
+	}
+}
+
+// List returns the names of all plugins.
+func (p *pluginClient) List(ctx context.Context) ([]string, error) {
+	log.Debugw("try to list plugins' names in APISIX",
+		zap.String("cluster", "default"),
+		zap.String("url", p.url),
+	)
+	pluginList, err := p.cluster.getList(ctx, p.url+"/list")
+	if err != nil {
+		log.Errorf("failed to list plugins' names: %s", err)
+		return nil, err
+	}

Review comment:
       add a debug log to show the plugin list.

##########
File path: pkg/apisix/plugin_test.go
##########
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package apisix
+
+import (
+	"context"
+	"encoding/json"
+	"github.com/stretchr/testify/assert"

Review comment:
       Please categorize the imports.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org