[GitHub] [incubator-pinot] adriancole commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

[GitBox <gi...@apache.org>]

adriancole commented on pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-706823255


   > High-level comment, AddTable is a very specific role and seems to solve one specific problem. Its probably better to either enhance the minion role to perform a task or add a new role (pinot-admin) and add table can be passed as a task. This will allow us to add more setup tasks without having to add a new role for each task.
   
   ok just also consider the configuration aspect of this. an addTable role looks like serializing inputs to the existing CLI commands or the REST api. it is also a fairly cardinal thing in a database to add a table.
   
   Regardless, this is more a task than a service. I don't know if minions do tasks, but something to consider.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org