You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/06/29 06:46:06 UTC
[GitHub] zeppelin pull request #1105: [ZEPPELIN-385] Notebook offline view mode
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1105
[ZEPPELIN-385] Notebook offline view mode
### What is this PR for?
This PR is to address so called `offline view` (view only + offline mode) mode. In this mode you open notebook in `only view` mode meaning can't do any editions + notebook and paragraph bars are disabled. Further, it's called `offline`, in case someone else does any changes in the notebook while you have it open, the changes will not be rendered in your screen until you reload it. There was initial work under #389, however some notable differences exist. For example, same functionality here available from frontend menu without need to restart Zeppelin. Also it provides `offline` view which was absent in initial PR.
### What type of PR is it?
Feature
### Todos
* [x] - basic frontend implementation
* [ ] - address comments + green CI
### What is the Jira issue?
related to [ZEPPELIN-385](https://issues.apache.org/jira/browse/ZEPPELIN-385)
### How should this be tested?
1. open any notebook
2. click `offline view` from the dropdown menu of notebook `looknfeel` bar on the top right
3. try to edit note or do any changes
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Possibly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin notebook/offlineView
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1105
----
commit bdf5203c3f650a433141130eb03da9876cb7acf1
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2016-06-24T17:27:52Z
initial implemenation of offline view
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by ashishr-wizni <gi...@git.apache.org>.
Github user ashishr-wizni commented on the issue:
https://github.com/apache/zeppelin/pull/1105
Copying from Zeppelin mailing list:
It's not clear to me if offline mode would allow changing input controls (dropdowns/input box etc) and view the new result. Our requirement is for a dashboard mode, where multiple users can play with the data using the input controls but don't interfere with each other's work. This is a very basic requirement for making Dashboards using Zeppelin.
I think isolating a notebook copy in a web socket/user session (in Dashboard mode), can achieve the desired results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov do you think we can close this one now, until you look into it more again? Or is it WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov may be we should consider enabling show/hide editor and output buttons
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov one thing: as soon as this changes the URL - you might want to double-check and make sure that URLs to each separate paragraph (+IFrame ones) and a Search work with new URL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@bzz thanks for ping, i'm closing it for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov 1 week ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by dceashish <gi...@git.apache.org>.
Github user dceashish commented on the issue:
https://github.com/apache/zeppelin/pull/1105
Copying from Zeppelin Dev List:
It's not clear to me if offline mode would allow changing input controls (dropdowns/input box etc) and view the new result. Our requirement is for a dashboard mode, where multiple users can play with the data using the input controls but don't interfere with each other's work. This is a very basic requirement for making Dashboards using Zeppelin.
I think isolating a notebook copy in a web socket/user session (in Dashboard mode), can achieve the desired results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1105
I'm not sure what the usage of this feature as if would be.
#389 was aiming at having a view only experience at a time when auth was not implemented.
In our case it would make more sense to link this feature to the notebook user access settings, especially since only changing the url would still allow to access it in edit mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/1105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@r-kamath that's good point, but that differs according to use cases (also as a workaround, possible to set those before switching to `offline link`). from point of view having `offline view`, no changes on notebook should be displayed and basically any paragraph updates are blocked to render in [here](https://github.com/apache/zeppelin/pull/1105/files#diff-52fa6628f0b6793d22ffe1f3e4763635R350), which includes updates from show/hide editor and output forms. However it can be reconsidered depending on more feedback on use cases.
@corneadoug it makes some sense, however `view only` isn't the only feature. i updated the description with second screenshot on `offline view`. anyways, I'll look more into how it goes along with the authentication and get back here.
@bzz thanks for feedback, i'll look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---