You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by StevenMPhillips <gi...@git.apache.org> on 2014/04/10 20:38:25 UTC
[GitHub] incubator-drill pull request: DRILL-498 cast to varchar only retur...
GitHub user StevenMPhillips opened a pull request:
https://github.com/apache/incubator-drill/pull/48
DRILL-498 cast to varchar only returns one row
The problem was that the column reader was not using the set or setSafe interface for writing to a vector, but was writing directly to the buffers. So when DRILL-417 was fixed, this no longer worked.
The fix was to use the proper interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StevenMPhillips/incubator-drill DRILL-498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-drill/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 7e87d3054b73b6865aa920d06355e1afa5161630
Author: Steven Phillips <sp...@maprtech.com>
Date: 2014-04-10T03:03:37Z
DRILL-498 cast to varchar only returns one row
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-drill pull request: DRILL-498 cast to varchar only retur...
Posted by adityakishore <gi...@git.apache.org>.
Github user adityakishore commented on the pull request:
https://github.com/apache/incubator-drill/pull/48#issuecomment-40960103
Merged as e2bb54188e060b79bc8bc478390af01a7ab91f10. Steven, could you please close this pull request as done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-drill pull request: DRILL-498 cast to varchar only retur...
Posted by StevenMPhillips <gi...@git.apache.org>.
Github user StevenMPhillips closed the pull request at:
https://github.com/apache/incubator-drill/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---