You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/30 12:40:33 UTC

[GitHub] [pinot] lksvenoy-r7 opened a new pull request, #8801: Fix bug in IngestionUtils creating segment uri to tar map

lksvenoy-r7 opened a new pull request, #8801:
URL: https://github.com/apache/pinot/pull/8801

   Fix bug in IngestionUtils where a list of segment URIs is converted to its string list representation, when it should have been converting each URI to its string representation.
   
   Previously this code path would fail with
   
   ```
   Caused by: java.net.URISyntaxException: Illegal character in path at index 0:
   at java.base/java.net.URI$Parser.fail(URI.java:2913)
   	at java.base/java.net.URI$Parser.checkChars(URI.java:3084)
   	at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3166)
   	at java.base/java.net.URI$Parser.parse(URI.java:3125)
   	at java.base/java.net.URI.<init>(URI.java:600)
   	at java.base/java.net.URI.create(URI.java:881)
   	... 19 more
   ```
   
   At line 309 in SegmentPushUtils:
   ```
     URI uri = URI.create(file);
         if (uri.getPath().endsWith(Constants.TAR_GZ_FILE_EXT)) {
           URI updatedURI = SegmentPushUtils.generateSegmentTarURI(outputDirURI, uri, pushSpec.getSegmentUriPrefix(),
               pushSpec.getSegmentUriSuffix());
           segmentUriToTarPathMap.put(updatedURI.toString(), file);
         }
       }
       return segmentUriToTarPathMap;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] lksvenoy-r7 closed pull request #8801: Fix bug in IngestionUtils creating segment uri to tar map

Posted by GitBox <gi...@apache.org>.
lksvenoy-r7 closed pull request #8801: Fix bug in IngestionUtils creating segment uri to tar map
URL: https://github.com/apache/pinot/pull/8801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org