You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/01 17:33:29 UTC

[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6096: Spark: Optimize Preconditions.checkArgument in procedures

ajantha-bhat opened a new pull request, #6096:
URL: https://github.com/apache/iceberg/pull/6096

   Removed the redundant space before `value`, and avoid the string concatenation by passing the `maxConcurrentDeletes` as an argument.
   
   This is a follow-up, found after https://github.com/apache/iceberg/pull/6083.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures

Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6096:
URL: https://github.com/apache/iceberg/pull/6096#issuecomment-1299540222

   Now again build failed because of an old flaky test (https://github.com/apache/iceberg/issues/6060).
   Not sure whether the env is flaky, because got a `java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: GC overhead limit exceeded`
   
   https://github.com/apache/iceberg/actions/runs/3374426458/jobs/5600033069#step:6:247
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko merged pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures

Posted by GitBox <gi...@apache.org>.
Fokko merged PR #6096:
URL: https://github.com/apache/iceberg/pull/6096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures

Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6096:
URL: https://github.com/apache/iceberg/pull/6096#issuecomment-1299537500

   TIL: Spotless by default applies only to the default versions (i,e spark-3.3). Hence build failed. 
   
   I will update [README.md ](https://github.com/apache/iceberg#building) about passing all versions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat commented on pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures

Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6096:
URL: https://github.com/apache/iceberg/pull/6096#issuecomment-1298877644

   cc: @Fokko 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] ajantha-bhat closed pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures

Posted by GitBox <gi...@apache.org>.
ajantha-bhat closed pull request #6096: Spark: Optimize Preconditions.checkArgument in procedures
URL: https://github.com/apache/iceberg/pull/6096


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org