You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/10 18:03:06 UTC

[GitHub] [activemq-artemis] tabish121 commented on a change in pull request #3448: [ARTEMIS-3113]: Artemis AMQP shouldn't depend on JMS.

tabish121 commented on a change in pull request #3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r573953735



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AMQPMessageSupport.java
##########
@@ -396,7 +364,8 @@ private static CoreMessage newMessage(long id, byte messageType, CoreMessageObje
    }
 
 
-   public static byte destinationType(Destination destination) {
+   // IMPORTANT-TODO: HOW TO GET THIS?

Review comment:
       I'm confused, if this is important than why commit the change before having figured that bit out, if it isn't then why leave this whole bit of commented out code here ?  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org