[jira] [Commented] (AIRFLOW-6699) Parameterize weekday sensor tests

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027825#comment-17027825 ] 

ASF GitHub Bot commented on AIRFLOW-6699:
-----------------------------------------

coopergillan commented on pull request #7315: [AIRFLOW-6699] Parameterize weekday_sensor tests
URL: https://github.com/apache/airflow/pull/7315
 
 
   Using `pytest`, consolidate the "True" or "happy path" tests into one parameterized test that uses a new TRUE_TESTS_CONFIG to drive test names and the `week_day` parameter.
   
   Update all tests to use `pytest`, including regex matching on the failing tests as needed.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Parameterize weekday sensor tests
> ---------------------------------
>
>                 Key: AIRFLOW-6699
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6699
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 1.10.7
>            Reporter: Cooper Gillan
>            Assignee: Cooper Gillan
>            Priority: Minor
>
> Many of the arguments for the true tests in tests/sensors/test_weekday_sensor.py are repeated. The tests are also running with unittest.TestCase rather than pytest.
> Make use of pytest's parametrize functionality to use the same base tests for true tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)