[GitHub] [spark] dgd-contributor commented on a change in pull request #33836: [SPARK-36293][SQL] Refactor fourth set of 20 query execution errors to use error classes

[GitBox <gi...@apache.org>]

dgd-contributor commented on a change in pull request #33836:
URL: https://github.com/apache/spark/pull/33836#discussion_r714068723



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/AnalysisException.scala
##########
@@ -94,3 +97,21 @@ class AnalysisException protected[sql] (
   override def getErrorClass: String = errorClass.orNull
   override def getSqlState: String = SparkThrowableHelper.getSqlState(errorClass.orNull)
 }
+
+class SparkInternalCompilerException(errorClass: String, messageParameters: Array[String])

Review comment:
       Thanks @karenfeng , I think SQL Catalyst is the good place to put those new exception. And if we put them to ```core/.../SparkException.scala``` we will need add ```org.codehaus.janino``` dependency in core's ```pom.xml```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org