You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/17 15:29:04 UTC
[GitHub] [inlong] luchunliang opened a new pull request, #5093: [INLONG-5092][SortSdk]Change Kafka default partition assignment strategy to RangeAssignor
luchunliang opened a new pull request, #5093:
URL: https://github.com/apache/inlong/pull/5093
### Prepare a Pull Request
- Title: [INLONG-5092][SortSdk]Change Kafka default partition assignment strategy to RangeAssignor
- Fixes #5092
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5093: [INLONG-5092][SDK] Change Kafka default partition assignment strategy to RangeAssignor
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5093:
URL: https://github.com/apache/inlong/pull/5093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5093: [INLONG-5092][SDK] Change Kafka default partition assignment strategy to RangeAssignor
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5093:
URL: https://github.com/apache/inlong/pull/5093#discussion_r922944945
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/kafka/AckOffsetOnRebalance.java:
##########
@@ -19,43 +19,43 @@
package org.apache.inlong.sdk.sort.impl.kafka;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.Collection;
+import java.util.concurrent.ConcurrentHashMap;
+
public class AckOffsetOnRebalance implements ConsumerRebalanceListener {
private final Logger logger = LoggerFactory.getLogger(AckOffsetOnRebalance.class);
+ private final String clusterId;
private final KafkaConsumer<byte[], byte[]> consumer;
private final ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap;
- public AckOffsetOnRebalance(KafkaConsumer<byte[], byte[]> consumer,
+ public AckOffsetOnRebalance(String clusterId, KafkaConsumer<byte[], byte[]> consumer,
ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap) {
+ this.clusterId = clusterId;
this.consumer = consumer;
this.commitOffsetMap = commitOffsetMap;
}
@Override
public void onPartitionsRevoked(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsRevoked");
Review Comment:
The log info should be standardized, and the use of special characters is not recommended.
```java
logger.debug("execute Rebalance:onPartitionsRevoked");
```
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/kafka/AckOffsetOnRebalance.java:
##########
@@ -19,43 +19,43 @@
package org.apache.inlong.sdk.sort.impl.kafka;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.Collection;
+import java.util.concurrent.ConcurrentHashMap;
+
public class AckOffsetOnRebalance implements ConsumerRebalanceListener {
private final Logger logger = LoggerFactory.getLogger(AckOffsetOnRebalance.class);
+ private final String clusterId;
private final KafkaConsumer<byte[], byte[]> consumer;
private final ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap;
- public AckOffsetOnRebalance(KafkaConsumer<byte[], byte[]> consumer,
+ public AckOffsetOnRebalance(String clusterId, KafkaConsumer<byte[], byte[]> consumer,
ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap) {
+ this.clusterId = clusterId;
this.consumer = consumer;
this.commitOffsetMap = commitOffsetMap;
}
@Override
public void onPartitionsRevoked(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsRevoked");
- while (!commitOffsetMap.isEmpty()) {
- consumer.commitSync(commitOffsetMap);
- }
+ collection.forEach((v) -> {
+ logger.info("clusterId:{},onPartitionsRevoked:{}", clusterId, v.toString());
+ });
}
@Override
public void onPartitionsAssigned(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsAssigned ");
Review Comment:
The log info should be standardized, and the use of special characters is not recommended.
```java
logger.debug("execute Rebalance:onPartitionsAssigned");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5093: [INLONG-5092][SDK] Change Kafka default partition assignment strategy to RangeAssignor
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5093:
URL: https://github.com/apache/inlong/pull/5093#issuecomment-1186684112
@yunqingmoswu @gong PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5093: [INLONG-5092][SDK] Change Kafka default partition assignment strategy to RangeAssignor
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5093:
URL: https://github.com/apache/inlong/pull/5093#discussion_r922937277
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsarzone/PulsarClusterProducer.java:
##########
@@ -282,6 +281,27 @@ public boolean send(DispatchProfile event) {
}
}
+ /**
+ * getProducerTopic
+ * @param event
+ * @return
Review Comment:
no description for return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] luchunliang commented on a diff in pull request #5093: [INLONG-5092][SDK] Change Kafka default partition assignment strategy to RangeAssignor
Posted by GitBox <gi...@apache.org>.
luchunliang commented on code in PR #5093:
URL: https://github.com/apache/inlong/pull/5093#discussion_r922946908
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsarzone/PulsarClusterProducer.java:
##########
@@ -282,6 +281,27 @@ public boolean send(DispatchProfile event) {
}
}
+ /**
+ * getProducerTopic
+ * @param event
+ * @return
Review Comment:
add description
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/kafka/AckOffsetOnRebalance.java:
##########
@@ -19,43 +19,43 @@
package org.apache.inlong.sdk.sort.impl.kafka;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.Collection;
+import java.util.concurrent.ConcurrentHashMap;
+
public class AckOffsetOnRebalance implements ConsumerRebalanceListener {
private final Logger logger = LoggerFactory.getLogger(AckOffsetOnRebalance.class);
+ private final String clusterId;
private final KafkaConsumer<byte[], byte[]> consumer;
private final ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap;
- public AckOffsetOnRebalance(KafkaConsumer<byte[], byte[]> consumer,
+ public AckOffsetOnRebalance(String clusterId, KafkaConsumer<byte[], byte[]> consumer,
ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap) {
+ this.clusterId = clusterId;
this.consumer = consumer;
this.commitOffsetMap = commitOffsetMap;
}
@Override
public void onPartitionsRevoked(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsRevoked");
Review Comment:
fixed
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/kafka/AckOffsetOnRebalance.java:
##########
@@ -19,43 +19,43 @@
package org.apache.inlong.sdk.sort.impl.kafka;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.Collection;
+import java.util.concurrent.ConcurrentHashMap;
+
public class AckOffsetOnRebalance implements ConsumerRebalanceListener {
private final Logger logger = LoggerFactory.getLogger(AckOffsetOnRebalance.class);
+ private final String clusterId;
private final KafkaConsumer<byte[], byte[]> consumer;
private final ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap;
- public AckOffsetOnRebalance(KafkaConsumer<byte[], byte[]> consumer,
+ public AckOffsetOnRebalance(String clusterId, KafkaConsumer<byte[], byte[]> consumer,
ConcurrentHashMap<TopicPartition, OffsetAndMetadata> commitOffsetMap) {
+ this.clusterId = clusterId;
this.consumer = consumer;
this.commitOffsetMap = commitOffsetMap;
}
@Override
public void onPartitionsRevoked(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsRevoked");
- while (!commitOffsetMap.isEmpty()) {
- consumer.commitSync(commitOffsetMap);
- }
+ collection.forEach((v) -> {
+ logger.info("clusterId:{},onPartitionsRevoked:{}", clusterId, v.toString());
+ });
}
@Override
public void onPartitionsAssigned(Collection<TopicPartition> collection) {
logger.debug("*- in ralance:onPartitionsAssigned ");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org