You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 15:23:26 UTC
[GitHub] [incubator-superset] kkucharc commented on a change in pull request #12153: fix: Add visibility to box for viewing menu items
kkucharc commented on a change in pull request #12153:
URL: https://github.com/apache/incubator-superset/pull/12153#discussion_r551381114
##########
File path: superset-frontend/src/dashboard/stylesheets/components/chart.less
##########
@@ -23,7 +23,7 @@
background-color: @lightest;
position: relative;
padding: 16px;
- overflow-y: auto;
+ overflow-y: visible;
Review comment:
Unfortunately this change will affect `Region Filter`:
`overflow-y: visible` (now):
<img width="150" alt="Screenshot 2021-01-04 at 16 15 00" src="https://user-images.githubusercontent.com/2536609/103549981-83583380-4ea8-11eb-8416-998369f2029c.png">
and `overflow-y: auto` (was):
<img width="141" alt="Screenshot 2021-01-04 at 16 14 46" src="https://user-images.githubusercontent.com/2536609/103550008-8e12c880-4ea8-11eb-98e9-5c9c485fb26f.png">
I changed scroll solution back [here](https://github.com/apache/incubator-superset/issues/11419) but I believe there must be some better solution here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org