You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2013/12/01 20:48:26 UTC
Re: trunk build fails for different reasons on different times
Hi Thiago,
PMD etc are very good tools but on technical code it just brings to wrong fixes.
Some tcks are now failling cause you implemented hashCode in
LazyWebAppClassLoader which has a lot of tricky side effects. Normally
I fixed it (my fix is a bit poor but there is a comment on why on
possible nexts, I can't go further ATM but any help is welcomed).
BTW we need to redo the new Random with the salt JL commited but
without breaking tests...otherwise no need to use random at all ;)
++
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2013/11/29 Thiago Veronezi <th...@veronezi.org>:
> Cool... subversion en francais. :)
> I will try that shortly. Tkx!
>
> []s,
> Thiago.
> On Nov 29, 2013 6:26 AM, "Jean-Louis MONTEIRO" <je...@gmail.com> wrote:
>
>> Hi Thiago,
>>
>> I committed 2 possible related changes.
>> First ...
>> svn ci -m "Add a salt when initializing the Random"
>> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
>> svn ci Envoi
>> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
>> Transmission des données .-m "
>> Révision 1545643 propagée.
>>
>> Second ...
>> svn ci -m "OPENEJB-2048 Add a DirectConnectionFactory to the client side
>> for simple cases"
>> src/main/java/org/apache/openejb/client/ConnectionManager.java
>> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
>> Envoi
>> src/main/java/org/apache/openejb/client/ConnectionManager.java
>> Ajout
>> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
>> Transmission des données ..
>> Révision 1545645 propagée.
>>
>> The second one does not seem the culprit but the first one maybe is.
>> I was in my opinion a good idea, but looks like it wasn't or tests are
>> broken ;-)
>>
>> The change is really small so just revert it maybe and let's see what
>> happens.
>> The change in RandomConnectionStrategy.java was ...
>> - private final Random random = new Random();
>> + private final Random random = new
>> Random(System.currentTimeMillis());
>>
>>
>> Hope that helps
>> Jean-Louis
>>
>>
>>
>>
>> 2013/11/29 Thiago Veronezi <th...@veronezi.org>
>>
>> > Hi guys,
>> > Are you guys facing the same problem? Trunk build fails for different
>> > reasons at different times.
>> >
>> > build 753
>> > ******************************************************
>> >
>> >
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> > Time elapsed: 0.27 sec <<< FAILURE!
>> > java.lang.AssertionError: expected:<2> but was:<0>
>> > at org.junit.Assert.fail(Assert.java:88)
>> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> > at org.junit.Assert.assertEquals(Assert.java:118)
>> > at org.junit.Assert.assertEquals(Assert.java:555)
>> > at org.junit.Assert.assertEquals(Assert.java:542)
>> > at
>> >
>> >
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> > ******************************************************
>> >
>> > build 752
>> > ******************************************************
>> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.067
>> sec
>> > <<< FAILURE!
>> > test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest)
>> Time
>> > elapsed: 18.996 sec <<< FAILURE!
>> > java.lang.AssertionError: Bad number of invocations for the bean "blue".
>> > expected:<2> but was:<1>
>> > at org.junit.Assert.fail(Assert.java:88)
>> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> > at org.junit.Assert.assertEquals(Assert.java:118)
>> > at org.junit.Assert.assertEquals(Assert.java:555)
>> > at
>> >
>> >
>> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:219)
>> > at
>> >
>> >
>> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:173)
>> >
>> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.234 sec
>> > <<< FAILURE!
>> >
>> >
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> > Time elapsed: 0.364 sec <<< FAILURE!
>> > java.lang.AssertionError: expected:<2> but was:<0>
>> > at org.junit.Assert.fail(Assert.java:88)
>> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> > at org.junit.Assert.assertEquals(Assert.java:118)
>> > at org.junit.Assert.assertEquals(Assert.java:555)
>> > at org.junit.Assert.assertEquals(Assert.java:542)
>> > at
>> >
>> >
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> > ******************************************************
>> >
>> > build 751
>> > ******************************************************
>> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.532
>> sec
>> > <<< FAILURE!
>> > test(org.apache.openejb.itest.legacy.LegacyServerTest) Time elapsed:
>> > 19.462 sec <<< FAILURE!
>> > java.lang.AssertionError: 22 out of 1000 is too low
>> > at org.junit.Assert.fail(Assert.java:88)
>> > at org.junit.Assert.assertTrue(Assert.java:41)
>> > at
>> >
>> >
>> org.apache.openejb.itest.legacy.LegacyServerTest.assertBalance(LegacyServerTest.java:223)
>> > at
>> >
>> >
>> org.apache.openejb.itest.legacy.LegacyServerTest.test(LegacyServerTest.java:172)
>> >
>> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.132 sec
>> > <<< FAILURE!
>> >
>> >
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> > Time elapsed: 0.337 sec <<< FAILURE!
>> > java.lang.AssertionError: expected:<2> but was:<0>
>> > at org.junit.Assert.fail(Assert.java:88)
>> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> > at org.junit.Assert.assertEquals(Assert.java:118)
>> > at org.junit.Assert.assertEquals(Assert.java:555)
>> > at org.junit.Assert.assertEquals(Assert.java:542)
>> > at
>> >
>> >
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> > ******************************************************
>> >
>> > Do you see what may be going on? The funny thing is that if I retry the
>> > build from the latest failure point, those particular tests pass.
>> >
>> > So, imagine I run "mvn clean install" and the "trunk/itests/failover"
>> > fails. If I run "mvn clean install -rf failover", it will most likely
>> pass.
>> >
>> > Any idea?
>> >
>> > []s,
>> > Thiago.
>> >
>>
>>
>>
>> --
>> Jean-Louis
>>
Re: trunk build fails for different reasons on different times
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Test IMO
Le 2 déc. 2013 22:33, "Thiago Veronezi" <th...@veronezi.org> a écrit :
> Yeap, not committing it back.
>
> The salt breaks the tests for the same reason as
>
> http://ci.apache.org/builders/tomee-trunk-ubuntu/builds/737/steps/test-results/logs/stdio
>
>
> *****************************************************************************************************************************
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.228 sec
> <<< FAILURE!
> test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest) Time
> elapsed: 31.148 sec <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:216)
> at
>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:203)
>
> *****************************************************************************************************************************
>
> Any idea of what is broken? Tests or feature?
>
> []s,
> Thiago.
>
>
>
>
> On Mon, Dec 2, 2013 at 3:29 PM, Thiago Veronezi <th...@veronezi.org>
> wrote:
>
> > Yay! First local tests "Build Success" after many months! :)
> >
> > >>BTW we need to redo the new Random with the salt JL commited but
> without
> > breaking tests...otherwise no need to use random at all ;)
> > I've changed back the code and I'm running my local tests again. If it
> > doesn't break the build, I will commit it back. (~3 hrs)
> >
> > []s,
> > Thiago.
> >
> >
> >
> > On Sun, Dec 1, 2013 at 2:48 PM, Romain Manni-Bucau <
> rmannibucau@gmail.com>wrote:
> >
> >> Hi Thiago,
> >>
> >> PMD etc are very good tools but on technical code it just brings to
> wrong
> >> fixes.
> >>
> >> Some tcks are now failling cause you implemented hashCode in
> >> LazyWebAppClassLoader which has a lot of tricky side effects. Normally
> >> I fixed it (my fix is a bit poor but there is a comment on why on
> >> possible nexts, I can't go further ATM but any help is welcomed).
> >>
> >> BTW we need to redo the new Random with the salt JL commited but
> >> without breaking tests...otherwise no need to use random at all ;)
> >>
> >> ++
> >> Romain Manni-Bucau
> >> Twitter: @rmannibucau
> >> Blog: http://rmannibucau.wordpress.com/
> >> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >> Github: https://github.com/rmannibucau
> >>
> >>
> >>
> >> 2013/11/29 Thiago Veronezi <th...@veronezi.org>:
> >> > Cool... subversion en francais. :)
> >> > I will try that shortly. Tkx!
> >> >
> >> > []s,
> >> > Thiago.
> >> > On Nov 29, 2013 6:26 AM, "Jean-Louis MONTEIRO" <je...@gmail.com>
> >> wrote:
> >> >
> >> >> Hi Thiago,
> >> >>
> >> >> I committed 2 possible related changes.
> >> >> First ...
> >> >> svn ci -m "Add a salt when initializing the Random"
> >> >> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
> >> >> svn ci Envoi
> >> >>
> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
> >> >> Transmission des données .-m "
> >> >> Révision 1545643 propagée.
> >> >>
> >> >> Second ...
> >> >> svn ci -m "OPENEJB-2048 Add a DirectConnectionFactory to the client
> >> side
> >> >> for simple cases"
> >> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
> >> >> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
> >> >> Envoi
> >> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
> >> >> Ajout
> >> >>
> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
> >> >> Transmission des données ..
> >> >> Révision 1545645 propagée.
> >> >>
> >> >> The second one does not seem the culprit but the first one maybe is.
> >> >> I was in my opinion a good idea, but looks like it wasn't or tests
> are
> >> >> broken ;-)
> >> >>
> >> >> The change is really small so just revert it maybe and let's see what
> >> >> happens.
> >> >> The change in RandomConnectionStrategy.java was ...
> >> >> - private final Random random = new Random();
> >> >> + private final Random random = new
> >> >> Random(System.currentTimeMillis());
> >> >>
> >> >>
> >> >> Hope that helps
> >> >> Jean-Louis
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> 2013/11/29 Thiago Veronezi <th...@veronezi.org>
> >> >>
> >> >> > Hi guys,
> >> >> > Are you guys facing the same problem? Trunk build fails for
> different
> >> >> > reasons at different times.
> >> >> >
> >> >> > build 753
> >> >> > ******************************************************
> >> >> >
> >> >> >
> >> >>
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> >> > Time elapsed: 0.27 sec <<< FAILURE!
> >> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> >> > at org.junit.Assert.fail(Assert.java:88)
> >> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> >> > ******************************************************
> >> >> >
> >> >> > build 752
> >> >> > ******************************************************
> >> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> >> 19.067
> >> >> sec
> >> >> > <<< FAILURE!
> >> >> >
> test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest)
> >> >> Time
> >> >> > elapsed: 18.996 sec <<< FAILURE!
> >> >> > java.lang.AssertionError: Bad number of invocations for the bean
> >> "blue".
> >> >> > expected:<2> but was:<1>
> >> >> > at org.junit.Assert.fail(Assert.java:88)
> >> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:219)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:173)
> >> >> >
> >> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> >> 1.234 sec
> >> >> > <<< FAILURE!
> >> >> >
> >> >> >
> >> >>
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> >> > Time elapsed: 0.364 sec <<< FAILURE!
> >> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> >> > at org.junit.Assert.fail(Assert.java:88)
> >> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> >> > ******************************************************
> >> >> >
> >> >> > build 751
> >> >> > ******************************************************
> >> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> >> 19.532
> >> >> sec
> >> >> > <<< FAILURE!
> >> >> > test(org.apache.openejb.itest.legacy.LegacyServerTest) Time
> elapsed:
> >> >> > 19.462 sec <<< FAILURE!
> >> >> > java.lang.AssertionError: 22 out of 1000 is too low
> >> >> > at org.junit.Assert.fail(Assert.java:88)
> >> >> > at org.junit.Assert.assertTrue(Assert.java:41)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.itest.legacy.LegacyServerTest.assertBalance(LegacyServerTest.java:223)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.itest.legacy.LegacyServerTest.test(LegacyServerTest.java:172)
> >> >> >
> >> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> >> 1.132 sec
> >> >> > <<< FAILURE!
> >> >> >
> >> >> >
> >> >>
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> >> > Time elapsed: 0.337 sec <<< FAILURE!
> >> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> >> > at org.junit.Assert.fail(Assert.java:88)
> >> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> >> > at
> >> >> >
> >> >> >
> >> >>
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> >> > ******************************************************
> >> >> >
> >> >> > Do you see what may be going on? The funny thing is that if I retry
> >> the
> >> >> > build from the latest failure point, those particular tests pass.
> >> >> >
> >> >> > So, imagine I run "mvn clean install" and the
> "trunk/itests/failover"
> >> >> > fails. If I run "mvn clean install -rf failover", it will most
> likely
> >> >> pass.
> >> >> >
> >> >> > Any idea?
> >> >> >
> >> >> > []s,
> >> >> > Thiago.
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Jean-Louis
> >> >>
> >>
> >
> >
>
Re: trunk build fails for different reasons on different times
Posted by Thiago Veronezi <th...@veronezi.org>.
Yeap, not committing it back.
The salt breaks the tests for the same reason as
http://ci.apache.org/builders/tomee-trunk-ubuntu/builds/737/steps/test-results/logs/stdio
*****************************************************************************************************************************
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.228 sec
<<< FAILURE!
test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest) Time
elapsed: 31.148 sec <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:216)
at
org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:203)
*****************************************************************************************************************************
Any idea of what is broken? Tests or feature?
[]s,
Thiago.
On Mon, Dec 2, 2013 at 3:29 PM, Thiago Veronezi <th...@veronezi.org> wrote:
> Yay! First local tests "Build Success" after many months! :)
>
> >>BTW we need to redo the new Random with the salt JL commited but without
> breaking tests...otherwise no need to use random at all ;)
> I've changed back the code and I'm running my local tests again. If it
> doesn't break the build, I will commit it back. (~3 hrs)
>
> []s,
> Thiago.
>
>
>
> On Sun, Dec 1, 2013 at 2:48 PM, Romain Manni-Bucau <rm...@gmail.com>wrote:
>
>> Hi Thiago,
>>
>> PMD etc are very good tools but on technical code it just brings to wrong
>> fixes.
>>
>> Some tcks are now failling cause you implemented hashCode in
>> LazyWebAppClassLoader which has a lot of tricky side effects. Normally
>> I fixed it (my fix is a bit poor but there is a comment on why on
>> possible nexts, I can't go further ATM but any help is welcomed).
>>
>> BTW we need to redo the new Random with the salt JL commited but
>> without breaking tests...otherwise no need to use random at all ;)
>>
>> ++
>> Romain Manni-Bucau
>> Twitter: @rmannibucau
>> Blog: http://rmannibucau.wordpress.com/
>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>> Github: https://github.com/rmannibucau
>>
>>
>>
>> 2013/11/29 Thiago Veronezi <th...@veronezi.org>:
>> > Cool... subversion en francais. :)
>> > I will try that shortly. Tkx!
>> >
>> > []s,
>> > Thiago.
>> > On Nov 29, 2013 6:26 AM, "Jean-Louis MONTEIRO" <je...@gmail.com>
>> wrote:
>> >
>> >> Hi Thiago,
>> >>
>> >> I committed 2 possible related changes.
>> >> First ...
>> >> svn ci -m "Add a salt when initializing the Random"
>> >> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
>> >> svn ci Envoi
>> >> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
>> >> Transmission des données .-m "
>> >> Révision 1545643 propagée.
>> >>
>> >> Second ...
>> >> svn ci -m "OPENEJB-2048 Add a DirectConnectionFactory to the client
>> side
>> >> for simple cases"
>> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
>> >> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
>> >> Envoi
>> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
>> >> Ajout
>> >> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
>> >> Transmission des données ..
>> >> Révision 1545645 propagée.
>> >>
>> >> The second one does not seem the culprit but the first one maybe is.
>> >> I was in my opinion a good idea, but looks like it wasn't or tests are
>> >> broken ;-)
>> >>
>> >> The change is really small so just revert it maybe and let's see what
>> >> happens.
>> >> The change in RandomConnectionStrategy.java was ...
>> >> - private final Random random = new Random();
>> >> + private final Random random = new
>> >> Random(System.currentTimeMillis());
>> >>
>> >>
>> >> Hope that helps
>> >> Jean-Louis
>> >>
>> >>
>> >>
>> >>
>> >> 2013/11/29 Thiago Veronezi <th...@veronezi.org>
>> >>
>> >> > Hi guys,
>> >> > Are you guys facing the same problem? Trunk build fails for different
>> >> > reasons at different times.
>> >> >
>> >> > build 753
>> >> > ******************************************************
>> >> >
>> >> >
>> >>
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> >> > Time elapsed: 0.27 sec <<< FAILURE!
>> >> > java.lang.AssertionError: expected:<2> but was:<0>
>> >> > at org.junit.Assert.fail(Assert.java:88)
>> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> >> > at org.junit.Assert.assertEquals(Assert.java:118)
>> >> > at org.junit.Assert.assertEquals(Assert.java:555)
>> >> > at org.junit.Assert.assertEquals(Assert.java:542)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> >> > ******************************************************
>> >> >
>> >> > build 752
>> >> > ******************************************************
>> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 19.067
>> >> sec
>> >> > <<< FAILURE!
>> >> > test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest)
>> >> Time
>> >> > elapsed: 18.996 sec <<< FAILURE!
>> >> > java.lang.AssertionError: Bad number of invocations for the bean
>> "blue".
>> >> > expected:<2> but was:<1>
>> >> > at org.junit.Assert.fail(Assert.java:88)
>> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> >> > at org.junit.Assert.assertEquals(Assert.java:118)
>> >> > at org.junit.Assert.assertEquals(Assert.java:555)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:219)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:173)
>> >> >
>> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 1.234 sec
>> >> > <<< FAILURE!
>> >> >
>> >> >
>> >>
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> >> > Time elapsed: 0.364 sec <<< FAILURE!
>> >> > java.lang.AssertionError: expected:<2> but was:<0>
>> >> > at org.junit.Assert.fail(Assert.java:88)
>> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> >> > at org.junit.Assert.assertEquals(Assert.java:118)
>> >> > at org.junit.Assert.assertEquals(Assert.java:555)
>> >> > at org.junit.Assert.assertEquals(Assert.java:542)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> >> > ******************************************************
>> >> >
>> >> > build 751
>> >> > ******************************************************
>> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 19.532
>> >> sec
>> >> > <<< FAILURE!
>> >> > test(org.apache.openejb.itest.legacy.LegacyServerTest) Time elapsed:
>> >> > 19.462 sec <<< FAILURE!
>> >> > java.lang.AssertionError: 22 out of 1000 is too low
>> >> > at org.junit.Assert.fail(Assert.java:88)
>> >> > at org.junit.Assert.assertTrue(Assert.java:41)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.itest.legacy.LegacyServerTest.assertBalance(LegacyServerTest.java:223)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.itest.legacy.LegacyServerTest.test(LegacyServerTest.java:172)
>> >> >
>> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 1.132 sec
>> >> > <<< FAILURE!
>> >> >
>> >> >
>> >>
>> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
>> >> > Time elapsed: 0.337 sec <<< FAILURE!
>> >> > java.lang.AssertionError: expected:<2> but was:<0>
>> >> > at org.junit.Assert.fail(Assert.java:88)
>> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
>> >> > at org.junit.Assert.assertEquals(Assert.java:118)
>> >> > at org.junit.Assert.assertEquals(Assert.java:555)
>> >> > at org.junit.Assert.assertEquals(Assert.java:542)
>> >> > at
>> >> >
>> >> >
>> >>
>> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
>> >> > ******************************************************
>> >> >
>> >> > Do you see what may be going on? The funny thing is that if I retry
>> the
>> >> > build from the latest failure point, those particular tests pass.
>> >> >
>> >> > So, imagine I run "mvn clean install" and the "trunk/itests/failover"
>> >> > fails. If I run "mvn clean install -rf failover", it will most likely
>> >> pass.
>> >> >
>> >> > Any idea?
>> >> >
>> >> > []s,
>> >> > Thiago.
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Jean-Louis
>> >>
>>
>
>
Re: trunk build fails for different reasons on different times
Posted by Thiago Veronezi <th...@veronezi.org>.
Yay! First local tests "Build Success" after many months! :)
>>BTW we need to redo the new Random with the salt JL commited but without
breaking tests...otherwise no need to use random at all ;)
I've changed back the code and I'm running my local tests again. If it
doesn't break the build, I will commit it back. (~3 hrs)
[]s,
Thiago.
On Sun, Dec 1, 2013 at 2:48 PM, Romain Manni-Bucau <rm...@gmail.com>wrote:
> Hi Thiago,
>
> PMD etc are very good tools but on technical code it just brings to wrong
> fixes.
>
> Some tcks are now failling cause you implemented hashCode in
> LazyWebAppClassLoader which has a lot of tricky side effects. Normally
> I fixed it (my fix is a bit poor but there is a comment on why on
> possible nexts, I can't go further ATM but any help is welcomed).
>
> BTW we need to redo the new Random with the salt JL commited but
> without breaking tests...otherwise no need to use random at all ;)
>
> ++
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
>
> 2013/11/29 Thiago Veronezi <th...@veronezi.org>:
> > Cool... subversion en francais. :)
> > I will try that shortly. Tkx!
> >
> > []s,
> > Thiago.
> > On Nov 29, 2013 6:26 AM, "Jean-Louis MONTEIRO" <je...@gmail.com>
> wrote:
> >
> >> Hi Thiago,
> >>
> >> I committed 2 possible related changes.
> >> First ...
> >> svn ci -m "Add a salt when initializing the Random"
> >> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
> >> svn ci Envoi
> >> src/main/java/org/apache/openejb/client/RandomConnectionStrategy.java
> >> Transmission des données .-m "
> >> Révision 1545643 propagée.
> >>
> >> Second ...
> >> svn ci -m "OPENEJB-2048 Add a DirectConnectionFactory to the client side
> >> for simple cases"
> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
> >> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
> >> Envoi
> >> src/main/java/org/apache/openejb/client/ConnectionManager.java
> >> Ajout
> >> src/main/java/org/apache/openejb/client/DirectConnectionStrategy.java
> >> Transmission des données ..
> >> Révision 1545645 propagée.
> >>
> >> The second one does not seem the culprit but the first one maybe is.
> >> I was in my opinion a good idea, but looks like it wasn't or tests are
> >> broken ;-)
> >>
> >> The change is really small so just revert it maybe and let's see what
> >> happens.
> >> The change in RandomConnectionStrategy.java was ...
> >> - private final Random random = new Random();
> >> + private final Random random = new
> >> Random(System.currentTimeMillis());
> >>
> >>
> >> Hope that helps
> >> Jean-Louis
> >>
> >>
> >>
> >>
> >> 2013/11/29 Thiago Veronezi <th...@veronezi.org>
> >>
> >> > Hi guys,
> >> > Are you guys facing the same problem? Trunk build fails for different
> >> > reasons at different times.
> >> >
> >> > build 753
> >> > ******************************************************
> >> >
> >> >
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> > Time elapsed: 0.27 sec <<< FAILURE!
> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> > at org.junit.Assert.fail(Assert.java:88)
> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> > ******************************************************
> >> >
> >> > build 752
> >> > ******************************************************
> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.067
> >> sec
> >> > <<< FAILURE!
> >> > test(org.apache.openejb.itest.failover.RandomConnectionStrategyTest)
> >> Time
> >> > elapsed: 18.996 sec <<< FAILURE!
> >> > java.lang.AssertionError: Bad number of invocations for the bean
> "blue".
> >> > expected:<2> but was:<1>
> >> > at org.junit.Assert.fail(Assert.java:88)
> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.assertBalance(RandomConnectionStrategyTest.java:219)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.itest.failover.RandomConnectionStrategyTest.test(RandomConnectionStrategyTest.java:173)
> >> >
> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.234
> sec
> >> > <<< FAILURE!
> >> >
> >> >
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> > Time elapsed: 0.364 sec <<< FAILURE!
> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> > at org.junit.Assert.fail(Assert.java:88)
> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> > ******************************************************
> >> >
> >> > build 751
> >> > ******************************************************
> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.532
> >> sec
> >> > <<< FAILURE!
> >> > test(org.apache.openejb.itest.legacy.LegacyServerTest) Time elapsed:
> >> > 19.462 sec <<< FAILURE!
> >> > java.lang.AssertionError: 22 out of 1000 is too low
> >> > at org.junit.Assert.fail(Assert.java:88)
> >> > at org.junit.Assert.assertTrue(Assert.java:41)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.itest.legacy.LegacyServerTest.assertBalance(LegacyServerTest.java:223)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.itest.legacy.LegacyServerTest.test(LegacyServerTest.java:172)
> >> >
> >> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.132
> sec
> >> > <<< FAILURE!
> >> >
> >> >
> >>
> test(org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest)
> >> > Time elapsed: 0.337 sec <<< FAILURE!
> >> > java.lang.AssertionError: expected:<2> but was:<0>
> >> > at org.junit.Assert.fail(Assert.java:88)
> >> > at org.junit.Assert.failNotEquals(Assert.java:743)
> >> > at org.junit.Assert.assertEquals(Assert.java:118)
> >> > at org.junit.Assert.assertEquals(Assert.java:555)
> >> > at org.junit.Assert.assertEquals(Assert.java:542)
> >> > at
> >> >
> >> >
> >>
> org.apache.openejb.arquillian.tests.cdi.ejb.OverloadedEjbObserverMethodsTest.test(OverloadedEjbObserverMethodsTest.java:68)
> >> > ******************************************************
> >> >
> >> > Do you see what may be going on? The funny thing is that if I retry
> the
> >> > build from the latest failure point, those particular tests pass.
> >> >
> >> > So, imagine I run "mvn clean install" and the "trunk/itests/failover"
> >> > fails. If I run "mvn clean install -rf failover", it will most likely
> >> pass.
> >> >
> >> > Any idea?
> >> >
> >> > []s,
> >> > Thiago.
> >> >
> >>
> >>
> >>
> >> --
> >> Jean-Louis
> >>
>