You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/12 12:36:43 UTC
[GitHub] [skywalking] muyun12 opened a new pull request #4503: Support
servlet 2.5 for Struts2
muyun12 opened a new pull request #4503: Support servlet 2.5 for Struts2
URL: https://github.com/apache/skywalking/pull/4503
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
[PR#3120](https://github.com/apache/skywalking/pull/3120)
[#2975](https://github.com/apache/skywalking/issues/2975)
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4503: Support servlet
2.5 for Struts2
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4503: Support servlet 2.5 for Struts2
URL: https://github.com/apache/skywalking/pull/4503#issuecomment-598180259
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=h1) Report
> Merging [#4503](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fdb816c799d468458c51ee019916b9afb75e4528&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4503 +/- ##
==========================================
- Coverage 25.55% 25.53% -0.02%
==========================================
Files 1244 1244
Lines 28843 28845 +2
Branches 3944 3944
==========================================
- Hits 7371 7366 -5
- Misses 20794 20801 +7
Partials 678 678
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/apm/plugin/struts2/Struts2Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/4503/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3RydXRzMi0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vc3RydXRzMi9TdHJ1dHMySW50ZXJjZXB0b3IuamF2YQ==) | `86.95% <66.66%> (+1.24%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4503/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=footer). Last update [fdb816c...488f77f](https://codecov.io/gh/apache/skywalking/pull/4503?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4503: Support servlet
2.5 for Struts2
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4503: Support servlet 2.5 for Struts2
URL: https://github.com/apache/skywalking/pull/4503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services