[GitHub] [incubator-superset] nytai commented on a change in pull request #10179: fix: row count container alignment

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10179:
URL: https://github.com/apache/incubator-superset/pull/10179#discussion_r446440487



##########
File path: superset-frontend/src/components/ListView/ListViewStyles.less
##########
@@ -134,6 +134,10 @@
     }
 
     .row-count-container {
+      float: right;

Review comment:
       let's just change this to 
   ```css
   float: right;
   margin-right: 20px;
   ```
   
   which should be enough to make this look OK on both the `/superset/welcome` and the `/tablemodelview/list/` pages with `ENABLE_REACT_CRUD_VIEWS` flag enabled. The `LIST_VIEWS_NEW_UI` flag is only related to the filters ui, you can update it to `LIST_VIEWS_NEW_FILTER_UI` to be more semantically correct if you're up for it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org