You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/16 07:14:57 UTC
[GitHub] [ozone] wycccccc opened a new pull request #1710: HDDS-4530. Add authorization check for SCM
wycccccc opened a new pull request #1710:
URL: https://github.com/apache/ozone/pull/1710
## What changes were proposed in this pull request?
Add authorization check about stopReplicationManager, forceExitSafeMode, startReplicationManager, deactivatePipeline, closePipeline in `SCMClientProtocolServer` .
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4530
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Add unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1710: HDDS-4530. Add authorization check for SCM
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1710:
URL: https://github.com/apache/ozone/pull/1710#issuecomment-759208647
Thax @elek review, I will try to create a jira to solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] vivekratnavel commented on pull request #1710: HDDS-4530. Add authorization check for SCM
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1710:
URL: https://github.com/apache/ozone/pull/1710#issuecomment-747624056
@wycccccc Can you please check if this integration test failure is related to this change?
```
Error: Failures:
Error: TestDecommissionAndMaintenance.testContainerIsReplicatedWhenAllNodesGotoMaintenance:394 expected:<5> but was:<6>
[INFO]
Error: Tests run: 213, Failures: 1, Errors: 0, Skipped: 15
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1710: HDDS-4530. Add authorization check for SCM
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1710:
URL: https://github.com/apache/ozone/pull/1710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1710: HDDS-4530. Add authorization check for SCM
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1710:
URL: https://github.com/apache/ozone/pull/1710#issuecomment-755228846
> I passed this test, no failure like this.So I think the failure is not related to this change.
We prefer to commit only green builds. If it's an intermittent test, there are two options:
1. Add an empty commit and have a green build
2. Disable the test with a simple commit on master and create a JIRA with the log which proves the intermittency.
Let me re-trigger this build...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wycccccc commented on pull request #1710: HDDS-4530. Add authorization check for SCM
Posted by GitBox <gi...@apache.org>.
wycccccc commented on pull request #1710:
URL: https://github.com/apache/ozone/pull/1710#issuecomment-749513767
@vivekratnavel I passed this test, no failure like this.So I think the failure is not related to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org