You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/14 01:01:38 UTC
[GitHub] [hadoop] sunchao opened a new pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
sunchao opened a new pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226
Currently for CI build and testing we maintain personality scripts in both Apache Yetus and Apache Hadoop. This poses problem when one needs to change both places, for example HADOOP-17125.
This proposes to move the personality file into the Hadoop repo itself, so that we can manage them in a single place. The downside for this is we may need to duplicate the scripts in every branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-674614743
In addition, I think we can revert https://github.com/apache/yetus/pull/46 in Hadoop repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#discussion_r471319019
##########
File path: Jenkinsfile
##########
@@ -96,8 +96,7 @@ pipeline {
YETUS_ARGS+=("--basedir=${WORKSPACE}/${SOURCEDIR}")
# our project defaults come from a personality file
- # which will get loaded automatically by setting the project name
- YETUS_ARGS+=("--project=hadoop")
Review comment:
Would you add `"--project=hadoop"`?
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console
The project name become 'unknown' and the name used in many places.
I'm +1 if that is addressed. Thank you @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-675172510
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on a change in pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#discussion_r471833557
##########
File path: Jenkinsfile
##########
@@ -96,8 +96,7 @@ pipeline {
YETUS_ARGS+=("--basedir=${WORKSPACE}/${SOURCEDIR}")
# our project defaults come from a personality file
- # which will get loaded automatically by setting the project name
- YETUS_ARGS+=("--project=hadoop")
Review comment:
Sure. Will add back. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-674725445
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 2s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 47s | trunk passed |
| +1 :green_heart: | mvnsite | 20m 19s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 19s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 9s | the patch passed |
| +1 :green_heart: | mvnsite | 17m 40s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 0s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 46s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. |
| | | 138m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2226 |
| Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit |
| uname | Linux c46257755145 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5092ea62ecb |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/testReport/ |
| Max. process+thread count | 477 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka merged pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
aajisaka merged pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a change in pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#discussion_r471191838
##########
File path: dev-support/bin/hadoop.sh
##########
@@ -0,0 +1,589 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#
+# SHELLDOC-IGNORE
+#
+# Override these to match Apache Hadoop's requirements
+personality_plugins "all,-ant,-gradle,-scalac,-scaladoc"
+
+## @description Globals specific to this personality
+## @audience private
+## @stability evolving
+function personality_globals
+{
+ # shellcheck disable=SC2034
+ BUILDTOOL=maven
+ #shellcheck disable=SC2034
+ PATCH_BRANCH_DEFAULT=trunk
+ #shellcheck disable=SC2034
+ PATCH_NAMING_RULE="https://wiki.apache.org/hadoop/HowToContribute"
+ #shellcheck disable=SC2034
+ JIRA_ISSUE_RE='^(HADOOP|YARN|MAPREDUCE|HDFS|HDDS|SUBMARINE)-[0-9]+$'
Review comment:
Now HDDS and SUBMARINE are developed in other repositories. They can be removed from the regex pattern.
```suggestion
JIRA_ISSUE_RE='^(HADOOP|YARN|MAPREDUCE|HDFS)-[0-9]+$'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-675219867
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 31m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 13s | trunk passed |
| +1 :green_heart: | mvnsite | 20m 13s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 8s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 18m 58s | the patch passed |
| +1 :green_heart: | mvnsite | 17m 6s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 7s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 20m 0s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 3s | The patch does not generate ASF License warnings. |
| | | 183m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2226 |
| Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit |
| uname | Linux 7cca94bd6377 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b367942fe49 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/testReport/ |
| Max. process+thread count | 414 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-674159050
@aajisaka : this adds personality file to the trunk. Once agreed on this I'll also add to other branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-673789517
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-673863895
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 50s | trunk passed |
| +1 :green_heart: | mvnsite | 20m 16s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 2s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 6s | the patch passed |
| +1 :green_heart: | mvnsite | 17m 10s | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 18s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 10s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 27s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. |
| | | 137m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2226 |
| Optional Tests | dupname asflicense shellcheck shelldocs mvnsite unit |
| uname | Linux 4184b6cdd2b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 86bbd38c8dc |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/testReport/ |
| Max. process+thread count | 450 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-674667643
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #2226: HADOOP-17205. Move personality file from Yetus to Hadoop repository
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2226:
URL: https://github.com/apache/hadoop/pull/2226#issuecomment-674666949
Thanks @aajisaka . Addressed your comments and re-triggering CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org