You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/23 02:03:01 UTC

[GitHub] [pulsar] saosir edited a comment on pull request #8606: fix cpp client AcknowledgeCumulative

saosir edited a comment on pull request #8606:
URL: https://github.com/apache/pulsar/pull/8606#issuecomment-731891030


   @BewareMyPower Sorry，I did not describe clearly. UnAckedMessageTrackerEnabled::removeMessagesTill should erase message whose id <= msgId in `messageIdPartitionMap`
   
   see [https://github.com/apache/pulsar/pull/8606/files](https://github.com/apache/pulsar/pull/8606/files), the origin implementation of cpp is different from that of  Java client. cpp client just earse `msgId`, not <= `msgId`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org