You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/02/26 21:00:35 UTC
[I] Optimize native shuffle for single partition case [datafusion-comet]
andygrove opened a new issue, #1453:
URL: https://github.com/apache/datafusion-comet/issues/1453
### What is the problem the feature request solves?
When native shuffle has a single output partition, we append the rows from the input batch into array builders and then create a new batch, which is identical to the input batch. We could skip all of this processing and just pass the batch though unmodified.
```rust
Partitioning::UnknownPartitioning(n) if *n == 1 => {
let buffered_partitions = &mut self.buffered_partitions;
assert!(
buffered_partitions.len() == 1,
"Expected 1 partition but got {}",
buffered_partitions.len()
);
let indices = (0..input.num_rows()).collect::<Vec<usize>>();
self.append_rows_to_partition(input.columns(), &indices, 0)
.await?;
```
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Optimize native shuffle for single partition case [datafusion-comet]
Posted by "dharanad (via GitHub)" <gi...@apache.org>.
dharanad commented on issue #1453:
URL: https://github.com/apache/datafusion-comet/issues/1453#issuecomment-2696503992
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Optimize native shuffle for single partition case [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #1453: Optimize native shuffle for single partition case
URL: https://github.com/apache/datafusion-comet/issues/1453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Optimize native shuffle for single partition case [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #1453:
URL: https://github.com/apache/datafusion-comet/issues/1453#issuecomment-2818523875
I think that we can close this issue now that native shuffle has been re-implemented to no longer use the builder approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org