You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/18 22:21:11 UTC

[GitHub] [geode] jhuynh1 commented on pull request #6028: WIP, DO NOT REVIEW. Do not create index when indexKey is null

jhuynh1 commented on pull request #6028:
URL: https://github.com/apache/geode/pull/6028#issuecomment-781672802


   Interesting change!  I'm going to think about it a bit, if none of the existing tests have failed, then I feel a bit more comfortable with this change.  It would be good to add a test for the scenario you were interested in fixing (maybe making sure the number of index mappings is < the number of entries.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org