You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/05/31 02:58:33 UTC
Review Request 22101: SENTRY-207: Sentry script should return non-zero exist
status in error conditions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22101/
-----------------------------------------------------------
Review request for sentry, Brock Noland and Prasad Mujumdar.
Bugs: SENTRY-207
https://issues.apache.org/jira/browse/SENTRY-207
Repository: sentry
Description
-------
Changed SentryService to implement Callable to be able to throw exceptions.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a0ac224bf03f36e0650af6ee784cc6608b5764e7
Diff: https://reviews.apache.org/r/22101/diff/
Testing
-------
Ran sentry service without initializing schema, and the error code was 1.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22101: SENTRY-207: Sentry script should return non-zero
exist status in error conditions
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22101/#review45025
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On June 4, 2014, 8:57 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22101/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 8:57 a.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-207
> https://issues.apache.org/jira/browse/SENTRY-207
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed SentryService to implement Callable to be able to throw exceptions.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java eefcb0aae4af0bbef1c8400f4b5713d244a907a0
>
> Diff: https://reviews.apache.org/r/22101/diff/
>
>
> Testing
> -------
>
> Ran sentry service without initializing schema, and the error code was 1.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22101: SENTRY-207: Sentry script should return non-zero
exist status in error conditions
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22101/
-----------------------------------------------------------
(Updated June 4, 2014, 8:57 a.m.)
Review request for sentry, Brock Noland and Prasad Mujumdar.
Bugs: SENTRY-207
https://issues.apache.org/jira/browse/SENTRY-207
Repository: sentry
Description
-------
Changed SentryService to implement Callable to be able to throw exceptions.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java eefcb0aae4af0bbef1c8400f4b5713d244a907a0
Diff: https://reviews.apache.org/r/22101/diff/
Testing
-------
Ran sentry service without initializing schema, and the error code was 1.
Thanks,
Sravya Tirukkovalur
Re: Review Request 22101: SENTRY-207: Sentry script should return non-zero
exist status in error conditions
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
> On June 3, 2014, 5:04 a.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java, line 156
> > <https://reviews.apache.org/r/22101/diff/1/?file=600278#file600278line156>
> >
> > It might be helpful to add the error message in the log. The catch block can rethrow the exception.
Makes sense, updating the patch.
- Sravya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22101/#review44599
-----------------------------------------------------------
On May 31, 2014, 12:58 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22101/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 12:58 a.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-207
> https://issues.apache.org/jira/browse/SENTRY-207
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed SentryService to implement Callable to be able to throw exceptions.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a0ac224bf03f36e0650af6ee784cc6608b5764e7
>
> Diff: https://reviews.apache.org/r/22101/diff/
>
>
> Testing
> -------
>
> Ran sentry service without initializing schema, and the error code was 1.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 22101: SENTRY-207: Sentry script should return non-zero
exist status in error conditions
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22101/#review44599
-----------------------------------------------------------
Ship it!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
<https://reviews.apache.org/r/22101/#comment79020>
It might be helpful to add the error message in the log. The catch block can rethrow the exception.
- Prasad Mujumdar
On May 31, 2014, 12:58 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22101/
> -----------------------------------------------------------
>
> (Updated May 31, 2014, 12:58 a.m.)
>
>
> Review request for sentry, Brock Noland and Prasad Mujumdar.
>
>
> Bugs: SENTRY-207
> https://issues.apache.org/jira/browse/SENTRY-207
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changed SentryService to implement Callable to be able to throw exceptions.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java a0ac224bf03f36e0650af6ee784cc6608b5764e7
>
> Diff: https://reviews.apache.org/r/22101/diff/
>
>
> Testing
> -------
>
> Ran sentry service without initializing schema, and the error code was 1.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>