You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/15 00:57:11 UTC
Review Request 38379: Handle empty set of cgroups as a no-op in
perf::sample.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38379/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Handle empty set of cgroups as a no-op in perf::sample.
Diffs
-----
src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724
src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
Diff: https://reviews.apache.org/r/38379/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler
Re: Review Request 38379: Handle empty set of cgroups as a no-op in
perf::sample.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38379/#review98949
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38379/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle empty set of cgroups as a no-op in perf::sample.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724
> src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
>
> Diff: https://reviews.apache.org/r/38379/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38379: Handle empty set of cgroups as a no-op in
perf::sample.
Posted by Ben Mahler <be...@gmail.com>.
> On Sept. 14, 2015, 11:21 p.m., Cong Wang wrote:
> > Not sure how much value this patch has, because upper layer always calls it with non-empty cgroups. Also, you probably want to check for events.empty() too while you are on it.
This was done for https://reviews.apache.org/r/38380/, which removes the special case logic for empty set.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38379/#review98945
-----------------------------------------------------------
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38379/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle empty set of cgroups as a no-op in perf::sample.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724
> src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
>
> Diff: https://reviews.apache.org/r/38379/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38379: Handle empty set of cgroups as a no-op in
perf::sample.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38379/#review98945
-----------------------------------------------------------
Not sure how much value this patch has, because upper layer always calls it with non-empty cgroups. Also, you probably want to check for events.empty() too while you are on it.
- Cong Wang
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38379/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Handle empty set of cgroups as a no-op in perf::sample.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724
> src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
>
> Diff: https://reviews.apache.org/r/38379/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>