You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/28 15:31:21 UTC
[PR] Support composite result columns routed to the same storage unit [shardingsphere]
terrymanu opened a new pull request, #39261:
URL: https://github.com/apache/shardingsphere/pull/39261
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support composite result columns routed to the same storage unit [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39261:
URL: https://github.com/apache/shardingsphere/pull/39261#issuecomment-5106238763
### Summary
**Review Result: Mergeable**
The PR correctly narrows the composite-result restriction to queries routed across different storage units. This is a code-scope result only; CI was not reviewed by request.
### Evidence
- `PostgreSQLJDBCResultMetadataChecker` now returns early when all execution units use the same storage unit (`PostgreSQLJDBCResultMetadataChecker.java:39-59`).
- openGauss is registered through its dialect SPI and delegates to the PostgreSQL checker.
- Tests cover PostgreSQL same-storage-unit routing, cross-storage-unit routing, and openGauss SPI loading.
### Review Details
- Review Focus: Code Correctness Review; CI not reviewed by request.
- Reviewed Scope: 5 changed files; head `a55a91e1923cbda7890aea7ea77df6f3f9edffd8`; base/merge-base `ce721c0b6bcab095bf84a745d6ea106e8b8a46f4`. Local file list matches the public PR scope.
- Not Reviewed Scope: GitHub Actions/CI and live database integration.
- Verification: Focused Maven tests passed, exit code 0. PostgreSQL: 6 tests; openGauss: 1 test.
- Release Note / User Docs: Not required; this is an internal compatibility correction without configuration or API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support composite result columns routed to the same storage unit [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39261:
URL: https://github.com/apache/shardingsphere/pull/39261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org