You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/03/09 17:25:24 UTC
Review Request 31861: RU: Inconsistent upgrade item statuses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31861/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Tom Beerbower.
Bugs: AMBARI-9984
https://issues.apache.org/jira/browse/AMBARI-9984
Repository: ambari
Description
-------
* Basically boils down to a typo for the ctor of the summary DTO. It took longer to write a verifying test than it did to fix the code.
* Fixed a PERSIST cascade that was breaking tests, but that annotation isn't realistic given that it's marked as nullable=false, so there's no way the entity could NOT exist already when creating a HostRoleCommandEntity
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java c5d447a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 6ab5aac
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java ffdcd6e
Diff: https://reviews.apache.org/r/31861/diff/
Testing
-------
Manual install + HA + upgrade test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:46.006s
[INFO] Finished at: Mon Mar 09 12:22:01 EDT 2015
[INFO] Final Memory: 27M/396M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 31861: RU: Inconsistent upgrade item statuses
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31861/#review75715
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 9, 2015, 12:25 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31861/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 12:25 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-9984
> https://issues.apache.org/jira/browse/AMBARI-9984
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Basically boils down to a typo for the ctor of the summary DTO. It took longer to write a verifying test than it did to fix the code.
> * Fixed a PERSIST cascade that was breaking tests, but that annotation isn't realistic given that it's marked as nullable=false, so there's no way the entity could NOT exist already when creating a HostRoleCommandEntity
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java c5d447a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 6ab5aac
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java ffdcd6e
>
> Diff: https://reviews.apache.org/r/31861/diff/
>
>
> Testing
> -------
>
> Manual install + HA + upgrade test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:46.006s
> [INFO] Finished at: Mon Mar 09 12:22:01 EDT 2015
> [INFO] Final Memory: 27M/396M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31861: RU: Inconsistent upgrade item statuses
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31861/#review75712
-----------------------------------------------------------
Ship it!
Good catch!
- Tom Beerbower
On March 9, 2015, 4:25 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31861/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 4:25 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-9984
> https://issues.apache.org/jira/browse/AMBARI-9984
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Basically boils down to a typo for the ctor of the summary DTO. It took longer to write a verifying test than it did to fix the code.
> * Fixed a PERSIST cascade that was breaking tests, but that annotation isn't realistic given that it's marked as nullable=false, so there's no way the entity could NOT exist already when creating a HostRoleCommandEntity
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java c5d447a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 6ab5aac
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java ffdcd6e
>
> Diff: https://reviews.apache.org/r/31861/diff/
>
>
> Testing
> -------
>
> Manual install + HA + upgrade test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:46.006s
> [INFO] Finished at: Mon Mar 09 12:22:01 EDT 2015
> [INFO] Final Memory: 27M/396M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31861: RU: Inconsistent upgrade item statuses
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31861/#review75714
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
<https://reviews.apache.org/r/31861/#comment122938>
I question how this ever worked since the host will always exist. Perhaps on real databases, EclipseLink is smart enough not to persist a managed entity with an ID, but on Derby it's not. Either way, I agree, this is not needed here.
- Jonathan Hurley
On March 9, 2015, 12:25 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31861/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 12:25 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
>
>
> Bugs: AMBARI-9984
> https://issues.apache.org/jira/browse/AMBARI-9984
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Basically boils down to a typo for the ctor of the summary DTO. It took longer to write a verifying test than it did to fix the code.
> * Fixed a PERSIST cascade that was breaking tests, but that annotation isn't realistic given that it's marked as nullable=false, so there's no way the entity could NOT exist already when creating a HostRoleCommandEntity
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java c5d447a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 6ab5aac
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RequestDAOTest.java ffdcd6e
>
> Diff: https://reviews.apache.org/r/31861/diff/
>
>
> Testing
> -------
>
> Manual install + HA + upgrade test
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:46.006s
> [INFO] Finished at: Mon Mar 09 12:22:01 EDT 2015
> [INFO] Final Memory: 27M/396M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>