Re: [PR] FINERACT-2668: Stop bulk-import loan-repayment template loading the entire tenant [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #6071:
URL: https://github.com/apache/fineract/pull/6071#discussion_r3504710657


##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java:
##########
@@ -448,6 +449,22 @@ public static class FineractTemplateProperties {
         private List<String> regexWhitelist;
     }
 
+    @Getter
+    @Setter
+    public static class FineractBulkImportProperties {
+
+        private FineractBulkImportTemplateProperties template;
+    }
+
+    @Getter
+    @Setter
+    public static class FineractBulkImportTemplateProperties {
+
+        // FINERACT-2668: max tenant-wide lookup rows (clients/loans) embedded in a download template before it
+        // auto-degrades to a lean form (typed keys only). Honoured by templates that opt in (loan repayment).
+        private int maxLookupRows = 10000;

Review Comment:
   No need for hardcoded value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org