You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/09/09 17:27:26 UTC

[GitHub] [helix] jiajunwang commented on pull request #2208: Unnecessary log removal

jiajunwang commented on PR #2208:
URL: https://github.com/apache/helix/pull/2208#issuecomment-1242262264

   Thanks for the following up @Marcosrico. Let's proceed with cautious. Even log is not necessary, it might still be a good idea to inject some information to the exception for supporting debug.
   
   I found this articial which presents a good idea,
   https://www.ibm.com/support/pages/best-practice-catching-and-re-throwing-java-exceptions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org