You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/01/03 00:16:04 UTC
[GitHub] kkhatua commented on a change in pull request #1591: DRILL-6933:
Fix ctrl+enter when Impersonation is disabled
kkhatua commented on a change in pull request #1591: DRILL-6933: Fix ctrl+enter when Impersonation is disabled
URL: https://github.com/apache/drill/pull/1591#discussion_r244890850
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##########
@@ -344,8 +344,8 @@ public String getOperatorsJSON() {
* @return true if impersonation is enabled without authentication,
* is needed to indicated if user name should be included when re-running the query
*/
- public boolean isOnlyImpersonationEnabled() {
- return onlyImpersonationEnabled;
+ public boolean isImpersonationOnlyEnabled() {
+ return impersonationOnlyEnabled;
Review comment:
I'm reflecting the actual method call's format https://github.com/apache/drill/blob/5ceff0a005b4fbfbb552275039a9af24f7f0f44b/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java#L131
Should I change this across the board then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services