You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/04/04 14:09:07 UTC

[GitHub] [incubator-mxnet] agrabows commented on a diff in pull request #20974: [BUGFIX] Fix bitwise_right_shift with uint input

agrabows commented on code in PR #20974:
URL: https://github.com/apache/incubator-mxnet/pull/20974#discussion_r841781742


##########
src/operator/mshadow_op.h:
##########
@@ -842,7 +842,10 @@ struct bitwise_right_shift : public mxnet_op::tunable {
         return DType(0);
       }
     }
-    return static_cast<int64_t>(a) >> static_cast<int64_t>(b);
+    if (std::is_same<DType, uint64_t>::value)

Review Comment:
   Good idea, it has been changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org