You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/14 20:51:26 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #1787: nRF: Incorrect base addresses for SPI controllers 1,2,3

btashton opened a new pull request #1787:
URL: https://github.com/apache/incubator-nuttx/pull/1787


   ## Summary
   The base address for SPIM{1,2,3} were are incorrectly set to the base for SPIM0
   
   ## Impact
   SPIM{1,2,3} are all functional
   
   ## Testing
   Tested on a configuration that uses for SPIM0 and SPIM1 in parallel with no issue
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #1787: nRF: Incorrect base addresses for SPI controllers 1,2,3

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1787:
URL: https://github.com/apache/incubator-nuttx/pull/1787#issuecomment-692309476


   LGTM. Do you want me to wait for CI anyway? The change is trivial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d merged pull request #1787: nRF: Incorrect base addresses for SPI controllers 1,2,3

Posted by GitBox <gi...@apache.org>.
v01d merged pull request #1787:
URL: https://github.com/apache/incubator-nuttx/pull/1787


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1787: nRF: Incorrect base addresses for SPI controllers 1,2,3

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1787:
URL: https://github.com/apache/incubator-nuttx/pull/1787#issuecomment-692313983


   > LGTM. Do you want me to wait for CI anyway? The change is trivial.
   
   I think it is obviously correct, but I'll leave that up to you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #1787: nRF: Incorrect base addresses for SPI controllers 1,2,3

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1787:
URL: https://github.com/apache/incubator-nuttx/pull/1787#issuecomment-692340890


   Ok, better to just wait for CI just to be sure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org