[GitHub] [kafka] clolov commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

["clolov (via GitHub)" <gi...@apache.org>]

clolov commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1233892585


##########
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##########
@@ -706,6 +706,8 @@ abstract class AbstractFetcherThread(name: String,
    *    - the request succeeded or
    *    - it was fenced and this thread hasn't received new epoch, which means we need not backoff and retry as the
    *    partition is moved to failed state.
+   *    - for ReplicaAlterLogDirsThread, "OutOfRange" error is generated when starting fetch to leader (source dir,

Review Comment:
   I believe a better way to explain the behaviour is that the OffsetOutOfRange error is used to ask the new replica (B) to set the offset it wants to fetch from to the earliest one available from A, but I will double-check my claim



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org