[GitHub] [incubator-nuttx] WaterBirdWayOrigin commented on issue #188: Fixed USB RNDIS not to send over MTU packet

[GitBox <gi...@apache.org>]

WaterBirdWayOrigin commented on issue #188: Fixed USB RNDIS not to send over MTU packet
URL: https://github.com/apache/incubator-nuttx/pull/188#issuecomment-581245103
 
 
   @patacongo 
   
   Thank you for your discussion with CONFIG_NET_GUARDSIZE.
   
   Does each of drivers have the responsibility of the limitation of ethernet packet length?
   If so, each of drivers may treat the appropriate ehternet packet length in it regardless of CONFIG_NET_GURARDSIZE.
   
   It seems to me that CONFIG_NET_GUARDSIZE is the spirit of uIP. I am not sure but
   if TCP/IP statemachine or checksum algorism doesn't need CONFIG_NET_GUARDSIZE, 
   this value can be removed from NuttX code.
   
   Upon reconsidering the matter, driver level modification such as USB RNDIS can limit
   an affected code area. When nobody uses CONFIG_NET_GUARDSIZE in driver, as well as TCP/IP statemachine and application, NuttX can remove this CONFIG safely.
   
   I will also discuss the lack of error handling of rndis_fillrequest() return 0 (Ethernet length is 0 and over CONFIG_NET_ETH_PKTSIZE). In this case,there is no RNDIS BULKIN header. I choose EINVAL in this case. Is this reasonable modification?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services