You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/30 01:34:28 UTC

[PR] Correct unknown provider fallback assertion [shardingsphere]

terrymanu opened a new pull request, #40011:
URL: https://github.com/apache/shardingsphere/pull/40011

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Correct unknown provider fallback assertion [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40011:
URL: https://github.com/apache/shardingsphere/pull/40011#issuecomment-5902323914

   ### Result
   **Review Result: Mergeable**
   
   Fixed the assertion in `CalciteSQLFederationProviderTest` to match the actual SPI behavior. No production code was changed.
   
   ### Evidence
   - Before the change, 1 of 8 tests failed because `UNKNOWN` did not throw the expected exception.
   - When the requested type is unavailable, `TypedSPILoader` selects the default provider, which is currently `NONE`. The test now checks that result.
   - After the change, all 8 focused tests passed. Spotless, Checkstyle, and `git diff --check` also passed.
   
   ### Coverage
   - Standalone local candidate, based on `45caa6250dd5af14c14c0ed585d7ffd5526cee6a`.
   - Reviewed only the task change to `kernel/sql-federation/provider/calcite/src/test/java/org/apache/shardingsphere/sqlfederation/provider/calcite/CalciteSQLFederationProviderTest.java`. No production code changes or unresolved issues were found.
   - This is a code correctness conclusion; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Correct unknown provider fallback assertion [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40011:
URL: https://github.com/apache/shardingsphere/pull/40011


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org