[jira] Commented: (AXIS2-495) ADB base64Binary handling

["Ajith Harshana Ranabahu (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/AXIS2-495?page=comments#action_12375337 ] 

Ajith Harshana Ranabahu commented on AXIS2-495:
-----------------------------------------------

This issue has been solved partly by adding the relevant properties to the ADBXmlStreamReader. Still the deserialization logic has to be optimized.

> ADB base64Binary handling
> -------------------------
>
>          Key: AXIS2-495
>          URL: http://issues.apache.org/jira/browse/AXIS2-495
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Improvement

>   Components: databinding
>     Reporter: Thilina Gunarathne
>     Assignee: Ajith Harshana Ranabahu

>
> I noticed that the code generated from ADB converts binary data back and forth in the case of Base64Binary schema type MTOM optimised contents.. AFA i understood this behaviour leads Axis2 to read the Binary data in MIME parts and converts them to Base64binary and then once again converts that Base64String to bytes... 
>  
>  object.setData(
>                   
>                      org.apache.axis2.databinding.utils.ConverterUtil.convertTobase64Binary(
>                            stateMachine2.getText()));
>  
> This behaviour is inefficient, can lead to serious memory issues and this will be a limiting factor for code generated services to handle large binary attachments....  
>  
> IMHO use of DataHandlers directly rather than encoding/re encoding binary back and forth is the correct way to go.. This is what we are doing in the OMTextImpl... In that case if data came as an attachment, then it won't undergo any conversions.. If they came in line as Base64 then they will decode to binary... 
>  
> We can either change the object.get/setData methods to use DataHandlers instead of byte[]. Or we can keep them as it is by getting and setting byte[] internally to data handler...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira