You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/08/05 23:34:14 UTC
[GitHub] [gobblin] arjun4084346 opened a new pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
arjun4084346 opened a new pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354
add some new metrics
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@jack-moseley @Will-Lo please review
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1508
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
add a few metrics in gobblin cluster and update some from counter to meter, because meter can give both count and rate of an entity
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
trivial changes
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d716165) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `4.00%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 42.42% -4.01%
+ Complexity 10115 4547 -5568
============================================
Files 2052 1025 -1027
Lines 79626 40660 -38966
Branches 8889 4537 -4352
============================================
- Hits 36970 17250 -19720
+ Misses 39216 21698 -17518
+ Partials 3440 1712 -1728
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.16% <0.00%> (ø)` | |
| [...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==) | `72.35% <0.00%> (ø)` | |
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...bblin/data/management/copy/OwnerAndPermission.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvT3duZXJBbmRQZXJtaXNzaW9uLmphdmE=) | | |
| ... and [1024 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...d716165](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 commented on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-895481007
@aplex please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#discussion_r685536515
##########
File path: gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -196,44 +197,48 @@ public void onCancelJob(URI cancelledJobURI) {
try {
_jobSpecQueue.put(new ImmutablePair<SpecExecutor.Verb, Spec>(SpecExecutor.Verb.UPDATE, updatedJob));
- _metrics.jobSpecEnqCount.incrementAndGet();
+ _metrics.specConsumerJobSpecEnq.mark();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
}
private class Metrics extends StandardMetricsBridge.StandardMetrics {
- private AtomicLong jobSpecEnqCount = new AtomicLong(0);
- private AtomicLong jobSpecDeqCount = new AtomicLong(0);
+ private final ContextAwareMeter specConsumerJobSpecEnq;
+ private final ContextAwareMeter specConsumerJobSpecDeq;
public static final String SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE = "specConsumerJobSpecQueueSize";
public static final String SPEC_CONSUMER_JOB_SPEC_ENQ = "specConsumerJobSpecEnq";
public static final String SPEC_CONSUMER_JOB_SPEC_DEQ = "specConsumerJobSpecDeq";
- public static final String SPEC_CONSUMER_JOB_SPEC_CONSUMED = "specConsumerJobSpecConsumed";
- public static final String SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES = "specConsumerJobSpecParseFailures";
public Metrics(MetricContext context) {
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE, ()->StreamingKafkaSpecConsumer.this._jobSpecQueue.size()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_ENQ, ()->jobSpecEnqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_DEQ, ()->jobSpecDeqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_CONSUMED,
- ()->getNewSpecs() + getRemovedSpecs() + getMessageParseFailures()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES, ()->getMessageParseFailures()));
+ this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE,
+ StreamingKafkaSpecConsumer.this._jobSpecQueue::size));
+ this.specConsumerJobSpecEnq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_ENQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecEnq);
+ this.specConsumerJobSpecDeq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_DEQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecDeq);
+ this.contextAwareMetrics.add(_jobMonitor.getNewSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getUpdatedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getRemovedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getCancelledSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getConsumedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getMessageParseFailures());
}
private long getNewSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs().getCount() : 0;
}
private long getRemovedSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs() != null?
- StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs().getCount() : 0;
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs() != null ?
+ StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs().getCount() : 0;
}
private long getMessageParseFailures() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures().getCount():0;
}
Review comment:
Ah, okay. I messed two PRs. removed this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77cd8c5) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `1.89%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
+ Coverage 46.42% 48.32% +1.89%
+ Complexity 10115 7517 -2598
============================================
Files 2052 1421 -631
Lines 79626 55888 -23738
Branches 8889 6435 -2454
============================================
- Hits 36970 27010 -9960
+ Misses 39216 26352 -12864
+ Partials 3440 2526 -914
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [637 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...77cd8c5](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77cd8c5) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
=========================================
Coverage 46.42% 46.43%
- Complexity 10115 10122 +7
=========================================
Files 2052 2052
Lines 79626 79660 +34
Branches 8889 8892 +3
=========================================
+ Hits 36970 36993 +23
- Misses 39216 39232 +16
+ Partials 3440 3435 -5
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...77cd8c5](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex merged pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
aplex merged pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley commented on a change in pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#discussion_r685483360
##########
File path: gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -196,44 +197,48 @@ public void onCancelJob(URI cancelledJobURI) {
try {
_jobSpecQueue.put(new ImmutablePair<SpecExecutor.Verb, Spec>(SpecExecutor.Verb.UPDATE, updatedJob));
- _metrics.jobSpecEnqCount.incrementAndGet();
+ _metrics.specConsumerJobSpecEnq.mark();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
}
private class Metrics extends StandardMetricsBridge.StandardMetrics {
- private AtomicLong jobSpecEnqCount = new AtomicLong(0);
- private AtomicLong jobSpecDeqCount = new AtomicLong(0);
+ private final ContextAwareMeter specConsumerJobSpecEnq;
+ private final ContextAwareMeter specConsumerJobSpecDeq;
public static final String SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE = "specConsumerJobSpecQueueSize";
public static final String SPEC_CONSUMER_JOB_SPEC_ENQ = "specConsumerJobSpecEnq";
public static final String SPEC_CONSUMER_JOB_SPEC_DEQ = "specConsumerJobSpecDeq";
- public static final String SPEC_CONSUMER_JOB_SPEC_CONSUMED = "specConsumerJobSpecConsumed";
- public static final String SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES = "specConsumerJobSpecParseFailures";
public Metrics(MetricContext context) {
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE, ()->StreamingKafkaSpecConsumer.this._jobSpecQueue.size()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_ENQ, ()->jobSpecEnqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_DEQ, ()->jobSpecDeqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_CONSUMED,
- ()->getNewSpecs() + getRemovedSpecs() + getMessageParseFailures()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES, ()->getMessageParseFailures()));
+ this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE,
+ StreamingKafkaSpecConsumer.this._jobSpecQueue::size));
+ this.specConsumerJobSpecEnq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_ENQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecEnq);
+ this.specConsumerJobSpecDeq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_DEQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecDeq);
+ this.contextAwareMetrics.add(_jobMonitor.getNewSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getUpdatedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getRemovedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getCancelledSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getConsumedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getMessageParseFailures());
}
private long getNewSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs().getCount() : 0;
}
private long getRemovedSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs() != null?
- StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs().getCount() : 0;
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs() != null ?
+ StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs().getCount() : 0;
}
private long getMessageParseFailures() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures().getCount():0;
}
Review comment:
Are these methods not used anymore? Can we just remove them if so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d716165) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
=========================================
Coverage 46.42% 46.43%
- Complexity 10115 10121 +6
=========================================
Files 2052 2052
Lines 79626 79669 +43
Branches 8889 8896 +7
=========================================
+ Hits 36970 36994 +24
- Misses 39216 39234 +18
- Partials 3440 3441 +1
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...d716165](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d716165) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `0.01%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 46.41% -0.02%
+ Complexity 10115 3070 -7045
============================================
Files 2052 644 -1408
Lines 79626 25102 -54524
Branches 8889 3000 -5889
============================================
- Hits 36970 11651 -25319
+ Misses 39216 12197 -27019
+ Partials 3440 1254 -2186
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.16% <0.00%> (ø)` | |
| [...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==) | `72.35% <0.00%> (ø)` | |
| [.../org/apache/gobblin/scheduler/SchedulerDaemon.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NjaGVkdWxlci9TY2hlZHVsZXJEYWVtb24uamF2YQ==) | | |
| [...ent/conversion/hive/source/BackfillHiveSource.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9zb3VyY2UvQmFja2ZpbGxIaXZlU291cmNlLmphdmE=) | | |
| ... and [1404 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...d716165](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9008380) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
=========================================
Coverage 46.42% 46.42%
- Complexity 10115 10118 +3
=========================================
Files 2052 2052
Lines 79626 79669 +43
Branches 8889 8896 +7
=========================================
+ Hits 36970 36990 +20
- Misses 39216 39240 +24
+ Partials 3440 3439 -1
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...9008380](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77cd8c5) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `0.78%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 45.64% -0.79%
+ Complexity 10115 8994 -1121
============================================
Files 2052 1802 -250
Lines 79626 71446 -8180
Branches 8889 7972 -917
============================================
- Hits 36970 32610 -4360
+ Misses 39216 35853 -3363
+ Partials 3440 2983 -457
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [258 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...77cd8c5](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9008380) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `0.03%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 46.39% -0.04%
+ Complexity 10115 3067 -7048
============================================
Files 2052 644 -1408
Lines 79626 25102 -54524
Branches 8889 3000 -5889
============================================
- Hits 36970 11646 -25324
+ Misses 39216 12203 -27013
+ Partials 3440 1253 -2187
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.16% <0.00%> (ø)` | |
| [...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==) | `72.35% <0.00%> (ø)` | |
| [.../kafka/client/AbstractBaseKafkaConsumerClient.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9BYnN0cmFjdEJhc2VLYWZrYUNvbnN1bWVyQ2xpZW50LmphdmE=) | | |
| [...ersion/finder/ModDateTimeDatasetVersionFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi92ZXJzaW9uL2ZpbmRlci9Nb2REYXRlVGltZURhdGFzZXRWZXJzaW9uRmluZGVyLmphdmE=) | | |
| [...che/gobblin/runtime/std/JobExecutionUpdatable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3RkL0pvYkV4ZWN1dGlvblVwZGF0YWJsZS5qYXZh) | | |
| ... and [1402 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...9008380](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c75b1f7) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `4.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 41.99% -4.44%
+ Complexity 10115 2606 -7509
============================================
Files 2052 631 -1421
Lines 79626 23772 -55854
Branches 8889 2457 -6432
============================================
- Hits 36970 9984 -26986
+ Misses 39216 12880 -26336
+ Partials 3440 908 -2532
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pache/gobblin/config/client/ConfigClientCache.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlnL2NsaWVudC9Db25maWdDbGllbnRDYWNoZS5qYXZh) | | |
| [.../java/org/apache/gobblin/writer/WriteCallback.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1dyaXRlQ2FsbGJhY2suamF2YQ==) | | |
| [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | | |
| [...org/apache/gobblin/cluster/SingleTaskLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFza0xhdW5jaGVyLmphdmE=) | | |
| [...lin/cluster/event/DeleteJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvRGVsZXRlSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | | |
| [...in/source/extractor/exception/SchemaException.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXhjZXB0aW9uL1NjaGVtYUV4Y2VwdGlvbi5qYXZh) | | |
| [.../gobblin/data/management/dataset/DummyDataset.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvRHVtbXlEYXRhc2V0LmphdmE=) | | |
| [...ache/gobblin/runtime/embedded/EmbeddedGobblin.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZW1iZWRkZWQvRW1iZWRkZWRHb2JibGluLmphdmE=) | | |
| [...gobblin/source/RegexBasedPartitionedRetriever.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9SZWdleEJhc2VkUGFydGl0aW9uZWRSZXRyaWV2ZXIuamF2YQ==) | | |
| ... and [1406 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...c75b1f7](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley commented on a change in pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#discussion_r685521959
##########
File path: gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -196,44 +197,48 @@ public void onCancelJob(URI cancelledJobURI) {
try {
_jobSpecQueue.put(new ImmutablePair<SpecExecutor.Verb, Spec>(SpecExecutor.Verb.UPDATE, updatedJob));
- _metrics.jobSpecEnqCount.incrementAndGet();
+ _metrics.specConsumerJobSpecEnq.mark();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
}
private class Metrics extends StandardMetricsBridge.StandardMetrics {
- private AtomicLong jobSpecEnqCount = new AtomicLong(0);
- private AtomicLong jobSpecDeqCount = new AtomicLong(0);
+ private final ContextAwareMeter specConsumerJobSpecEnq;
+ private final ContextAwareMeter specConsumerJobSpecDeq;
public static final String SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE = "specConsumerJobSpecQueueSize";
public static final String SPEC_CONSUMER_JOB_SPEC_ENQ = "specConsumerJobSpecEnq";
public static final String SPEC_CONSUMER_JOB_SPEC_DEQ = "specConsumerJobSpecDeq";
- public static final String SPEC_CONSUMER_JOB_SPEC_CONSUMED = "specConsumerJobSpecConsumed";
- public static final String SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES = "specConsumerJobSpecParseFailures";
public Metrics(MetricContext context) {
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE, ()->StreamingKafkaSpecConsumer.this._jobSpecQueue.size()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_ENQ, ()->jobSpecEnqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_DEQ, ()->jobSpecDeqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_CONSUMED,
- ()->getNewSpecs() + getRemovedSpecs() + getMessageParseFailures()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES, ()->getMessageParseFailures()));
+ this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE,
+ StreamingKafkaSpecConsumer.this._jobSpecQueue::size));
+ this.specConsumerJobSpecEnq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_ENQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecEnq);
+ this.specConsumerJobSpecDeq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_DEQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecDeq);
+ this.contextAwareMetrics.add(_jobMonitor.getNewSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getUpdatedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getRemovedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getCancelledSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getConsumedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getMessageParseFailures());
}
private long getNewSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs().getCount() : 0;
}
private long getRemovedSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs() != null?
- StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs().getCount() : 0;
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs() != null ?
+ StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs().getCount() : 0;
}
private long getMessageParseFailures() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures().getCount():0;
}
Review comment:
How are they being used? When I look at usages of this `private long getNewSpecs()` method I only see it used by the constructor right above (line 221), and you are removing that usage right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d716165) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `3.38%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 43.04% -3.39%
+ Complexity 10115 1942 -8173
============================================
Files 2052 394 -1658
Lines 79626 16888 -62738
Branches 8889 2080 -6809
============================================
- Hits 36970 7270 -29700
+ Misses 39216 8817 -30399
+ Partials 3440 801 -2639
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.16% <0.00%> (ø)` | |
| [...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==) | `72.35% <0.00%> (ø)` | |
| [...bblin/data/management/copy/OwnerAndPermission.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvT3duZXJBbmRQZXJtaXNzaW9uLmphdmE=) | | |
| [...va/org/apache/gobblin/runtime/api/JobTemplate.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYlRlbXBsYXRlLmphdmE=) | | |
| ... and [1653 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...d716165](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#discussion_r685518368
##########
File path: gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -196,44 +197,48 @@ public void onCancelJob(URI cancelledJobURI) {
try {
_jobSpecQueue.put(new ImmutablePair<SpecExecutor.Verb, Spec>(SpecExecutor.Verb.UPDATE, updatedJob));
- _metrics.jobSpecEnqCount.incrementAndGet();
+ _metrics.specConsumerJobSpecEnq.mark();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
}
private class Metrics extends StandardMetricsBridge.StandardMetrics {
- private AtomicLong jobSpecEnqCount = new AtomicLong(0);
- private AtomicLong jobSpecDeqCount = new AtomicLong(0);
+ private final ContextAwareMeter specConsumerJobSpecEnq;
+ private final ContextAwareMeter specConsumerJobSpecDeq;
public static final String SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE = "specConsumerJobSpecQueueSize";
public static final String SPEC_CONSUMER_JOB_SPEC_ENQ = "specConsumerJobSpecEnq";
public static final String SPEC_CONSUMER_JOB_SPEC_DEQ = "specConsumerJobSpecDeq";
- public static final String SPEC_CONSUMER_JOB_SPEC_CONSUMED = "specConsumerJobSpecConsumed";
- public static final String SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES = "specConsumerJobSpecParseFailures";
public Metrics(MetricContext context) {
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE, ()->StreamingKafkaSpecConsumer.this._jobSpecQueue.size()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_ENQ, ()->jobSpecEnqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_DEQ, ()->jobSpecDeqCount.get()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_CONSUMED,
- ()->getNewSpecs() + getRemovedSpecs() + getMessageParseFailures()));
- this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_PARSE_FAILURES, ()->getMessageParseFailures()));
+ this.contextAwareMetrics.add(context.newContextAwareGauge(SPEC_CONSUMER_JOB_SPEC_QUEUE_SIZE,
+ StreamingKafkaSpecConsumer.this._jobSpecQueue::size));
+ this.specConsumerJobSpecEnq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_ENQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecEnq);
+ this.specConsumerJobSpecDeq = context.contextAwareMeter(SPEC_CONSUMER_JOB_SPEC_DEQ);
+ this.contextAwareMetrics.add(this.specConsumerJobSpecDeq);
+ this.contextAwareMetrics.add(_jobMonitor.getNewSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getUpdatedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getRemovedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getCancelledSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getConsumedSpecs());
+ this.contextAwareMetrics.add(_jobMonitor.getMessageParseFailures());
}
private long getNewSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getNewSpecs().getCount() : 0;
}
private long getRemovedSpecs() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs() != null?
- StreamingKafkaSpecConsumer.this._jobMonitor.getRemovedSpecs().getCount() : 0;
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs() != null ?
+ StreamingKafkaSpecConsumer.this._jobMonitor.getCancelledSpecs().getCount() : 0;
}
private long getMessageParseFailures() {
- return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null?
+ return StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures() != null ?
StreamingKafkaSpecConsumer.this._jobMonitor.getMessageParseFailures().getCount():0;
}
Review comment:
They are being used. We might not seeing metrics so far, but that was due to a bug, which I am fixing in https://github.com/apache/gobblin/pull/3350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9008380) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `2.53%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
+ Coverage 46.42% 48.96% +2.53%
+ Complexity 10115 8641 -1474
============================================
Files 2052 1671 -381
Lines 79626 64111 -15515
Branches 8889 7359 -1530
============================================
- Hits 36970 31390 -5580
+ Misses 39216 29739 -9477
+ Partials 3440 2982 -458
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | `66.66% <80.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...ache/gobblin/runtime/api/JobExecutionLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvbkxhdW5jaGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| ... and [389 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...9008380](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77cd8c5) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `3.39%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 43.03% -3.40%
+ Complexity 10115 1942 -8173
============================================
Files 2052 394 -1658
Lines 79626 16879 -62747
Branches 8889 2076 -6813
============================================
- Hits 36970 7264 -29706
+ Misses 39216 8816 -30400
+ Partials 3440 799 -2641
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [...g/apache/gobblin/converter/jdbc/JdbcEntryData.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9qZGJjL0pkYmNFbnRyeURhdGEuamF2YQ==) | | |
| [...apache/gobblin/converter/parquet/ParquetGroup.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9QYXJxdWV0R3JvdXAuamF2YQ==) | | |
| [...bblin/runtime/api/MultiEventMetadataGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL011bHRpRXZlbnRNZXRhZGF0YUdlbmVyYXRvci5qYXZh) | | |
| [.../apache/gobblin/dataset/IterableDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9JdGVyYWJsZURhdGFzZXRGaW5kZXIuamF2YQ==) | | |
| [...ache/gobblin/publisher/TimestampDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9UaW1lc3RhbXBEYXRhUHVibGlzaGVyLmphdmE=) | | |
| ... and [1649 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...77cd8c5](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9008380) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **decrease** coverage by `3.41%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
- Coverage 46.42% 43.01% -3.42%
+ Complexity 10115 1940 -8175
============================================
Files 2052 394 -1658
Lines 79626 16888 -62738
Branches 8889 2080 -6809
============================================
- Hits 36970 7265 -29705
+ Misses 39216 8823 -30393
+ Partials 3440 800 -2640
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
| [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70.00% <60.00%> (ø)` | |
| [...obblin/cluster/GobblinHelixJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJNZXRyaWNzLmphdmE=) | `90.90% <90.90%> (ø)` | |
| [...luster/GobblinHelixPlanningJobLauncherMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4UGxhbm5pbmdKb2JMYXVuY2hlck1ldHJpY3MuamF2YQ==) | `70.58% <100.00%> (+1.83%)` | :arrow_up: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.46% <0.00%> (-0.33%)` | :arrow_down: |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.16% <0.00%> (ø)` | |
| [...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==) | `72.35% <0.00%> (ø)` | |
| [.../apache/gobblin/util/test/RetentionTestHelper.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdXRpbC90ZXN0L1JldGVudGlvblRlc3RIZWxwZXIuamF2YQ==) | | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | | |
| [...e/gobblin/runtime/api/GobblinInstanceLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0dvYmJsaW5JbnN0YW5jZUxhdW5jaGVyLmphdmE=) | | |
| ... and [1651 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...9008380](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3354: [GOBBLIN-1508] update some cluster side metrics from guage to meter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c75b1f7) into [master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f468bb0) will **increase** coverage by `6.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3354 +/- ##
============================================
+ Coverage 46.42% 53.37% +6.94%
+ Complexity 10115 1129 -8986
============================================
Files 2052 250 -1802
Lines 79626 8214 -71412
Branches 8889 920 -7969
============================================
- Hits 36970 4384 -32586
+ Misses 39216 3379 -35837
+ Partials 3440 451 -2989
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/gobblin/runtime/cli/CliEmbeddedGobblin.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvY2xpL0NsaUVtYmVkZGVkR29iYmxpbi5qYXZh) | | |
| [...ata/management/dataset/SimpleDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRGF0YXNldFJlcXVlc3Rvci5qYXZh) | | |
| [.../replication/ConfigBasedCopyableDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWRDb3B5YWJsZURhdGFzZXRGaW5kZXIuamF2YQ==) | | |
| [...ompaction/mapreduce/MRCompactorJobPropCreator.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9ySm9iUHJvcENyZWF0b3IuamF2YQ==) | | |
| [...time/spec\_executorInstance/MockedSpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19leGVjdXRvckluc3RhbmNlL01vY2tlZFNwZWNFeGVjdXRvci5qYXZh) | | |
| [.../src/main/java/org/apache/gobblin/util/Either.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRWl0aGVyLmphdmE=) | | |
| [...g/apache/gobblin/metastore/MysqlDataSourceKey.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsRGF0YVNvdXJjZUtleS5qYXZh) | | |
| [.../gobblin/runtime/api/JobSpecSchedulerListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYlNwZWNTY2hlZHVsZXJMaXN0ZW5lci5qYXZh) | | |
| [...erter/initializer/ConverterInitializerFactory.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9pbml0aWFsaXplci9Db252ZXJ0ZXJJbml0aWFsaXplckZhY3RvcnkuamF2YQ==) | | |
| [...ion/hive/dataset/ConvertibleHiveDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9kYXRhc2V0L0NvbnZlcnRpYmxlSGl2ZURhdGFzZXRGaW5kZXIuamF2YQ==) | | |
| ... and [1785 more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f468bb0...c75b1f7](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org