You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/11/22 13:01:12 UTC
[GitHub] [commons-compress] theobisproject opened a new pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
theobisproject opened a new pull request #152:
URL: https://github.com/apache/commons-compress/pull/152
As discussed in https://github.com/apache/commons-compress/pull/113 the problem can no longer be seen in newer Ubuntu versions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-734720960
> Should we investigate further?
Ubuntu 16.04 is using gnu tar whose version is 1.28, and 18.04 is using 1.29 instead.
According to the [releases description](https://www.gnu.org/software/tar/), the sparse detection is modified in version 1.29. After cloning the [gnu tar git](https://git.savannah.gnu.org/git/tar.git), I found that the commit `b68432` modified the sparse detection a lot.
I believe there're some potential problems about sparse detection in gnu tar 1.28, which was fixed in 1.29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-741300223
[](https://coveralls.io/builds/35553897)
Coverage decreased (-0.01%) to 87.273% when pulling **0c8be9c422b9aa9c6f7e0d9b2561d14dc10a5b19 on theobisproject:COMPRESS-559** into **05a995ee725f153b39be111c8b51adbed24d30a4 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-734183898
> Should we investigate further?
Trying to figure out what's wrong here. And I think we can have a comment here to indicate the test may fail on Ubuntu16.04.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-740448394
> Maybe we should also think about switching to some newer Ubuntu version in Travis since for 16.04 the standard support will end in April 2021.
I have made a [PR about this](https://github.com/apache/commons-compress/pull/156) and everything looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee merged pull request #152:
URL: https://github.com/apache/commons-compress/pull/152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] theobisproject commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
theobisproject commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-734880082
I also think the tar version 1.28 is simply broken for the archive we are extracting in the test. The file size is always 0. I could do a detection like the check for windows either if we are on Ubuntu 16.04 or the tar version available is 1.28. WDYT?
Maybe we should also think about switching to some newer Ubuntu version in Travis since for 16.04 the standard support will end in April 2021.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-737644603
> I could do a detection like the check for windows either if we are on Ubuntu 16.04 or the tar version available is 1.28. WDYT?
+1
> Maybe we should also think about switching to some newer Ubuntu version in Travis since for 16.04 the standard support will end in April 2021.
I'm working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee edited a comment on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee edited a comment on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-734720960
> Should we investigate further?
Ubuntu 16.04 is using gnu tar 1.28, and 18.04 is using gnu tar 1.29 instead.
According to the [releases description](https://www.gnu.org/software/tar/), the sparse detection is modified in version 1.29. After cloning the [gnu tar git](https://git.savannah.gnu.org/git/tar.git), I found that the commit `b68432` modified the sparse detection a lot.
I believe there're some potential problems about sparse detection in gnu tar 1.28, which was fixed in 1.29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] theobisproject commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
theobisproject commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-740938394
I finally found the time to add the check and test it. I've done the check for the tar version since this might also affect other distros with the same tar version if we only check for Ubuntu 16.04
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] theobisproject commented on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
theobisproject commented on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-731747864
The described problem seems to be still there on Ubuntu 16.04 since the test fails in Travis CI. Should we investigate further?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee edited a comment on pull request #152: COMPRESS-559: Extract sparsefile-0.1 also on Linux
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee edited a comment on pull request #152:
URL: https://github.com/apache/commons-compress/pull/152#issuecomment-734720960
> Should we investigate further?
Ubuntu 16.04 is using gnu tar 1.28, and Ubuntu 18.04 is using gnu tar 1.29 instead.
According to the [releases description](https://www.gnu.org/software/tar/), the sparse detection is modified in version 1.29. After cloning the [gnu tar git](https://git.savannah.gnu.org/git/tar.git), I found that the commit `b68432` modified the sparse detection a lot.
I believe there're some potential problems about sparse detection in gnu tar 1.28, which was fixed in 1.29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org