You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/08/27 07:50:57 UTC
[jira] Created: (THRIFT-873) Java tests fail due to Too many open
files
Java tests fail due to Too many open files
------------------------------------------
Key: THRIFT-873
URL: https://issues.apache.org/jira/browse/THRIFT-873
Project: Thrift
Issue Type: Test
Components: Java - Library
Affects Versions: 0.4
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.5
All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-873) Java tests fail due to Too many open
files
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903247#action_12903247 ]
Aaron T. Myers commented on THRIFT-873:
---------------------------------------
Patched worked for me flawlessly. Tests were failing for me before, and now they all pass.
> Java tests fail due to Too many open files
> ------------------------------------------
>
> Key: THRIFT-873
> URL: https://issues.apache.org/jira/browse/THRIFT-873
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Affects Versions: 0.4
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.5
>
> Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-873) Java tests fail due to Too many open
files
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated THRIFT-873:
-------------------------------
Attachment: thrift-873.txt
> Java tests fail due to Too many open files
> ------------------------------------------
>
> Key: THRIFT-873
> URL: https://issues.apache.org/jira/browse/THRIFT-873
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Affects Versions: 0.4
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.5
>
> Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-873) Java tests fail due to Too many open
files
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903456#action_12903456 ]
Todd Lipcon commented on THRIFT-873:
------------------------------------
On my box it goes a bit slower, but still pretty fast. With forkmode="once" I did indeed see failures that went away with the separate JVMs. It also made it harder to figure out which test was actually at fault, since the problem with AsyncClientManager caused a bunch of later tests to fail too.
> Java tests fail due to Too many open files
> ------------------------------------------
>
> Key: THRIFT-873
> URL: https://issues.apache.org/jira/browse/THRIFT-873
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Affects Versions: 0.4
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.5
>
> Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-873) Java tests fail due to Too many open
files
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903433#action_12903433 ]
Bryan Duxbury commented on THRIFT-873:
--------------------------------------
I like all of this patch except for the separate JVMs. I know that's its probably a more responsible way to do things, but it makes the test run slower. Are you certain that this is what is necessary in order to make the test pass? Wouldn't it be possible for us just to clean up after ourselves in the test for TAsyncClientManager?
> Java tests fail due to Too many open files
> ------------------------------------------
>
> Key: THRIFT-873
> URL: https://issues.apache.org/jira/browse/THRIFT-873
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Affects Versions: 0.4
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.5
>
> Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-873) Java tests fail due to Too many open
files
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved THRIFT-873.
--------------------------------
Resolution: Fixed
> Java tests fail due to Too many open files
> ------------------------------------------
>
> Key: THRIFT-873
> URL: https://issues.apache.org/jira/browse/THRIFT-873
> Project: Thrift
> Issue Type: Test
> Components: Java - Library
> Affects Versions: 0.4
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.5
>
> Attachments: thrift-873.txt
>
>
> All of the tests run in the same JVM, and it seems like TestAsyncClientManager is leaking sockets.
> As a quick fix, dropping that to use only 200 clients instead of 500, and changing each unit test to run in its own JVM instead of sharing them.
> Also allowing the port used for binding the test servers to be configured from the command line
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.