You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/07/20 18:45:12 UTC

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #6974: Fix Pkg Build Order to Mirror docker-compose.yml

zrhoffman commented on code in PR #6974:
URL: https://github.com/apache/trafficcontrol/pull/6974#discussion_r925948775


##########
pkg:
##########
@@ -155,7 +155,7 @@ while getopts h78abdf:lopqvsSL opt; do
 	esac
 done
 
-PROJECTS="$("${COMPOSECMD[@]}" -f $COMPOSE_FILE config --services)"
+PROJECTS="$(cat infrastructure/docker/build/docker-compose.yml | grep -E '^\s\s[a-zA-Z_-]+:$' | sed 's/[: ]//g')"

Review Comment:
   Parsing YAML with `grep` and `sed` does not seem so maintainable. What are your thoughts about rearranging the output of `docker-compose config --services` to have `weasel` first?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org