You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/07/14 10:37:59 UTC
[PR] Remove isCaseSensitive of DialectDatabaseMetaData and related tests [shardingsphere]
menghaoranss opened a new pull request, #39109:
URL: https://github.com/apache/shardingsphere/pull/39109
Changes proposed in this pull request:
- Remove isCaseSensitive of DialectDatabaseMetaData and related tests
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove isCaseSensitive of DialectDatabaseMetaData and related tests [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39109:
URL: https://github.com/apache/shardingsphere/pull/39109#issuecomment-4968635639
```markdown
### Summary
**Review Result: Mergeable**
Reason: Code-scope review only; CI not reviewed by request. I found no code-level blocker in the latest PR scope for removing `DialectDatabaseMetaData#isCaseSensitive()` and updating the related identifier policy fallback/test expectations.
### Evidence
- The PR removes `DialectDatabaseMetaData#isCaseSensitive()` from `database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/DialectDatabaseMetaData.java` and removes the only current dialect overrides in ClickHouse, PostgreSQL, and openGauss metadata classes.
- The remaining `isCaseSensitive()` references under the reviewed modules are column metadata or JDBC/result-set metadata paths, not the removed `DialectDatabaseMetaData` SPI method.
- `DefaultIdentifierCasePolicyProvider` now delegates only through `DialectDatabaseMetaData#getIdentifierPatternType()`, and `IdentifierCasePolicyFactoryTest` covers the resulting `LOWER_CASE`, `UPPER_CASE`, and `KEEP_ORIGIN` default policy behavior.
- The changed tests remove only assertions for the deleted SPI method and keep the surrounding dialect metadata behavior checks.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: latest PR head `105fab92da373477bfc26e096122d033932706b9`; base `master` at `9d2a76d810db5a16b6cb379231ebcc876e30bb9d`; local merge-base `9d2a76d810db5a16b6cb379231ebcc876e30bb9d`. Reviewed all 11 files returned by GitHub `/pulls/39109/files`; local `base...HEAD` file list matched GitHub.
- Not Reviewed Scope: GitHub Actions/check-runs and full repository `clean install` were not reviewed because this was a code-correctness review, not a mergeability/CI review.
- Verification: Ran `./mvnw -pl database/connector/core,database/connector/dialect/clickhouse,database/connector/dialect/postgresql,database/connector/dialect/opengauss,infra/common -DskipITs -Dspotless.skip=true -Dcheckstyle.skip=true -Dtest=DialectDatabaseMetaDataTest,IdentifierCasePolicyFactoryTest,ClickHouseDatabaseMetaDataTest,PostgreSQLDatabaseMetaDataTest,OpenGaussDatabaseMetaDataTest,IdentifierCasePolicyResolverTest,DefaultIdentifierCasePolicyProviderTest test -Dsurefire.failIfNoSpecifiedTests=false`; exit code `0`.
- Release Note / User Docs: Not required for this internal SPI cleanup; the PR does not introduce user-facing configuration, migration, troubleshooting, or compatibility guidance.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove isCaseSensitive of DialectDatabaseMetaData and related tests [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39109:
URL: https://github.com/apache/shardingsphere/pull/39109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org