[GitHub] [incubator-yunikorn-core] pbacsko commented on a change in pull request #356: [YUNIKORN-982] placeholder size checks

[GitBox <gi...@apache.org>]

pbacsko commented on a change in pull request #356:
URL: https://github.com/apache/incubator-yunikorn-core/pull/356#discussion_r781477109



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -827,13 +827,41 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
 			if ph.released || request.taskGroupName != ph.taskGroupName {
 				continue
 			}
+			// before we check anything we need to check the resources equality
+			delta := resources.Sub(ph.AllocatedResource, request.AllocatedResource)
+			// Any negative value in the delta means that at least one of the requested resource in the real
+			// allocation is larger than the placeholder. We need to cancel the placeholder and check the next
+			// placeholder. This should trigger a cleanup of all the placeholder as a task group is always one size.

Review comment:
       I would rephrase it as "task group has a size of one", sounds more correct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org