You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "thiagoelg (via GitHub)" <gi...@apache.org> on 2024/04/17 21:41:14 UTC
[PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
thiagoelg opened a new pull request, #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1570973350
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
Review Comment:
Hmm.. not sure, I've always used Temurin, since it's built on top of OpenJDK, and never had problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1571320364
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
Review Comment:
Sorry, that may have been an autocorrect from the Mac. Semeru, not Seamer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1569628451
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
Review Comment:
Is this the JDK version we want to be using? Should we use Seamer or OpenJDK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1569995041
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
+ "nodejs": "18.19.1",
+ "maven": "3.9.6",
+ "kubernetes-helm": "3.13.3",
+ "gnumake": "4.4.1",
+ "go": "1.21.8",
+ "python": "3.12.2",
+ "operator-sdk": "1.34.1",
+ "kubebuilder": "3.14.0"
Review Comment:
Should we have some sort of check to be sure we sync these versions with other places like `repo/build-dependencies-versions.json`
Maybe it could be some github action that read/parse json and compare the versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1570904571
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
+ "nodejs": "18.19.1",
+ "maven": "3.9.6",
+ "kubernetes-helm": "3.13.3",
+ "gnumake": "4.4.1",
+ "go": "1.21.8",
+ "python": "3.12.2",
+ "operator-sdk": "1.34.1",
+ "kubebuilder": "3.14.0"
Review Comment:
That would be great, but it's a bit cumbersome to do :/ Unfortunately the names are not a 1:1 to match, so having a check that more or less works doesn't bring much to us, IMHO. It's one more place to remember to update, yes, but not too big of a concern IMHO right now. In any case, thanks for bringing this up @jomarko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1570971179
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
+ "nodejs": "18.19.1",
+ "maven": "3.9.6",
+ "kubernetes-helm": "3.13.3",
+ "gnumake": "4.4.1",
+ "go": "1.21.8",
+ "python": "3.12.2",
+ "operator-sdk": "1.34.1",
+ "kubebuilder": "3.14.0"
Review Comment:
Thanks for looking into it @jomarko! As Tiago said, right now it's just one more place to update, but shouldn't be too hard, we just need to make sure that whatever package we are upgrading is available in nixpkgs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] NO-ISSUE: Add Nix-based development environment using devbox [incubator-kie-tools]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #2246:
URL: https://github.com/apache/incubator-kie-tools/pull/2246#discussion_r1570979428
##########
devbox.json:
##########
@@ -0,0 +1,30 @@
+{
+ "$schema": "https://raw.githubusercontent.com/jetpack-io/devbox/0.10.4/.schema/devbox.schema.json",
+ "packages": {
+ "temurin-bin-17": "17.0.9",
Review Comment:
I think we've been using temurin for awhile now. I don't know what Seamer distro is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org