You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/12/02 01:51:12 UTC

[kudu-CR] Fix flaky raft consensus failure detector-imc-itest 

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8721

to review the following change.


Change subject: Fix flaky raft_consensus_failure_detector-imc-itest
......................................................................

Fix flaky raft_consensus_failure_detector-imc-itest

When I wrote this test, I accidentally wrote it as if failure detection
was disabled, but of course failure detection cannot be disabled in this
failure detection test!

This was about 15% flaky before this patch. After the patch, 200/200
runs passed successfully.

Change-Id: I87dd39929d71ded5660508a383715883e00ccf8d
---
M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
1 file changed, 12 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/8721/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87dd39929d71ded5660508a383715883e00ccf8d
Gerrit-Change-Number: 8721
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] Fix flaky raft consensus failure detector-imc-itest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8721 )

Change subject: Fix flaky raft_consensus_failure_detector-imc-itest
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87dd39929d71ded5660508a383715883e00ccf8d
Gerrit-Change-Number: 8721
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 02 Dec 2017 02:09:05 +0000
Gerrit-HasComments: No

[kudu-CR] Fix flaky raft consensus failure detector-imc-itest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8721 )

Change subject: Fix flaky raft_consensus_failure_detector-imc-itest
......................................................................

Fix flaky raft_consensus_failure_detector-imc-itest

When I wrote this test, I accidentally wrote it as if failure detection
was disabled, but of course failure detection cannot be disabled in this
failure detection test!

This was about 15% flaky before this patch. After the patch, 200/200
runs passed successfully.

Change-Id: I87dd39929d71ded5660508a383715883e00ccf8d
Reviewed-on: http://gerrit.cloudera.org:8080/8721
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
1 file changed, 12 insertions(+), 14 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I87dd39929d71ded5660508a383715883e00ccf8d
Gerrit-Change-Number: 8721
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>