[GitHub] [maven-surefire] andpab commented on a diff in pull request #570: [SUREFIRE-2119] - Sanitize failIfNoSpecifiedTests prefix in failsafe

["andpab (via GitHub)" <gi...@apache.org>]

andpab commented on code in PR #570:
URL: https://github.com/apache/maven-surefire/pull/570#discussion_r1109517648


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -130,12 +130,24 @@
     private boolean useFile;
 
     /**
-     * Set this to "true" to cause a failure if none of the tests specified in -Dtest=... are run. Defaults to
+     * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
      * "true".
      *
      * @since 2.12
+     * @deprecated Since 3.0.0-M8, use "failsafe.failIfNoSpecifiedTests" instead.
      */
+    @Deprecated
     @Parameter( property = "it.failIfNoSpecifiedTests", defaultValue = "true" )
+    private boolean failIfNoSpecifiedTestsDeprecated;
+
+    /**
+     * Set this to "true" to cause a failure if none of the tests specified in -Dit.test=... are run. Defaults to
+     * "true".
+     * Replacing "it.failIfNoSpecifiedTests" to be consistent with surefire plugin.

Review Comment:
   I agree with your suggestion, but @liry did not change the wording here.
   
   Since there's no response from @liry, can the PR be merged anyway? In my fork I've rebased the branch to master. Builds were successful: https://github.com/andpab/maven-surefire/actions/runs/4198008135
   
   After the merge of this one I could make a new PR that adjusts the wording according to your suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org