You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/02 22:18:08 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #15056: [BEAM-10887] Timer clear

kennknowles commented on a change in pull request #15056:
URL: https://github.com/apache/beam/pull/15056#discussion_r663268046



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4851,6 +4851,342 @@ public void onTimer2(
         return PDone.in(input.getPipeline());
       }
     }
+

Review comment:
       The test Luke describes still seems useful. I would guess for most runners it will exercise the desired behavior. Since TestStream (by definition) waits for quiescence before processing the next phase runner's will typically bundle everything together because it will be queued up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org