You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/07/29 02:06:21 UTC
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/660
TAJO-1332 Implement Python Client for Tajo
This is implement of python tajo rest client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/tajo-python
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #660
----
commit ef73a5806b61a58dcd8aef33a3a5254876361dd8
Author: clark.kang <cl...@kakao.com>
Date: 2015-07-29T00:04:39Z
add tajo-python
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-133425813
I'm sorry for late review. The protocol between client and TajoMaster has been rapidly changed for better error propagation (https://issues.apache.org/jira/browse/TAJO-1625). This changes will actually affect REST API specification. I thought that this patch is conflict to the on-going error propagation work.
The solution is that we have to improve REST API to reflect the error propagation before we can continue this Python client. I think that REST API improvements would be trivial. We can put this python client into the next release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-140616185
Hi @charsyam
Thank you for your contribution.
Python has an API to make it easy to move from one SQL-based DB to another called DB-API. Each DB may have multiple different modules available for it. And if python users use it, they can easy integrate with ORM. It's documented in https://www.python.org/dev/peps/pep-0249.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-126538159
Nice work! On the proper location, I agree with you guys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-125786252
This is a PR just for discuss more.
we should discuss about testing and distribution and directory of this kind of clients.
I just put the python client into contrib/tajo-python
but it should be discussed for right position.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-125941435
Great work! I think that ``contrib`` seems to be a right position. I'll review it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by eminency <gi...@git.apache.org>.
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-173832814
Hi, @charsyam
May I take this on to continue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1332 Implement Python Client for Tajo
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/660#issuecomment-174154251
@eminency Thanks for your suggestion.
but, If you excuse. I will finish it ASAP
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---