You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2005/10/26 18:55:50 UTC

svn commit: r328674 - in /jakarta/tapestry/trunk: ./ framework/src/documentation/content/xdocs/tapestry/ComponentReference/ framework/src/java/org/apache/tapestry/ framework/src/java/org/apache/tapestry/engine/ framework/src/java/org/apache/tapestry/link/

Author: hlship
Date: Wed Oct 26 09:55:39 2005
New Revision: 328674

URL: http://svn.apache.org/viewcvs?rev=328674&view=rev
Log:
Deprecate the Action component and related code

Modified:
    jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IAction.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IRequestCycle.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionService.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionServiceParameter.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/RequestCycle.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.java
    jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.jwc
    jakarta/tapestry/trunk/status.xml

Modified: jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml (original)
+++ jakarta/tapestry/trunk/framework/src/documentation/content/xdocs/tapestry/ComponentReference/ActionLink.xml Wed Oct 26 09:55:39 2005
@@ -37,6 +37,12 @@
 
 </p>
 
+    <warning>
+      This component has been deprecated and will be removed in the next major release
+      of Tapestry. ActionLink represents an inherently unstable approach, since it can easily
+      be confused by changing server-side state.
+    </warning>
+
 <section>
   <title>Parameters</title>
 

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IAction.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IAction.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IAction.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IAction.java Wed Oct 26 09:55:39 2005
@@ -15,22 +15,20 @@
 package org.apache.tapestry;
 
 /**
- *  A particular type of component usuable with the
- *  action service.
- *
- *  @author Howard Lewis Ship
- *  @since 1.0.1
+ * A particular type of component usuable with the action service.
+ * 
+ * @author Howard Lewis Ship
+ * @since 1.0.1
+ * @deprecated To be removed in 4.1 with no replacement.
  */
 
 public interface IAction extends IComponent
 {
     /**
-     *  Returns true if the component requires 
-     *  an existing, not new, {@link javax.servlet.http.HttpSession}
-     *  to operate.  Components who are not dependant on page state
-     *  (or the visit object) are non-stateful and can return false.
-     *
-     **/
+     * Returns true if the component requires an existing, not new,
+     * {@link javax.servlet.http.HttpSession} to operate. Components who are not dependant on page
+     * state (or the visit object) are non-stateful and can return false.
+     */
 
     public boolean getRequiresSession();
 }

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IRequestCycle.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IRequestCycle.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IRequestCycle.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IRequestCycle.java Wed Oct 26 09:55:39 2005
@@ -89,6 +89,9 @@
     /**
      * Returns the next action id. ActionLink ids are used to identify different actions on a page
      * (URLs that are related to dynamic page state).
+     * 
+     * @deprecated To be removed in release 4.1 with no replacement.
+     * @see #getUniqueId(String)
      */
 
     public String getNextActionId();
@@ -148,6 +151,7 @@
      * 
      * @see IAction
      * @see org.apache.tapestry.link.ActionLink
+     * @deprecated To be removed in 4.1 with no replacement.
      */
 
     public void rewindPage(String targetActionId, IComponent targetComponent);

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionService.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionService.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionService.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionService.java Wed Oct 26 09:55:39 2005
@@ -39,6 +39,7 @@
  * 
  * @author Howard Lewis Ship
  * @since 1.0.9
+ * @deprecated To be removed in 4.1.
  */
 
 public class ActionService implements IEngineService

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionServiceParameter.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionServiceParameter.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionServiceParameter.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/ActionServiceParameter.java Wed Oct 26 09:55:39 2005
@@ -22,6 +22,7 @@
  * 
  * @author Howard M. Lewis Ship
  * @since 4.0
+ * @deprecated To be removed in 4.1.
  */
 public class ActionServiceParameter
 {

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/RequestCycle.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/RequestCycle.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/RequestCycle.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/engine/RequestCycle.java Wed Oct 26 09:55:39 2005
@@ -220,6 +220,7 @@
         return _monitor;
     }
 
+    /** @deprecated */
     public String getNextActionId()
     {
         return Integer.toHexString(++_actionId);
@@ -481,6 +482,8 @@
      * valid, and a {@link ApplicationRuntimeException}is thrown.
      * <p>
      * This clears all attributes.
+     * 
+     * @deprecated To be removed in 4.1 with no replacement.
      */
 
     public void rewindPage(String targetActionId, IComponent targetComponent)

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.java?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.java Wed Oct 26 09:55:39 2005
@@ -28,6 +28,7 @@
  * href="../../../../../ComponentReference/ActionLink.html">Component Reference </a>]
  * 
  * @author Howard Lewis Ship
+ * @deprecated To be removed in 4.1
  */
 
 public abstract class ActionLink extends AbstractLinkComponent implements IAction

Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.jwc
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.jwc?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.jwc (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/link/ActionLink.jwc Wed Oct 26 09:55:39 2005
@@ -19,11 +19,12 @@
   "-//Apache Software Foundation//Tapestry Specification 4.0//EN" 
   "http://jakarta.apache.org/tapestry/dtd/Tapestry_4_0.dtd">
   
-<component-specification class="org.apache.tapestry.link.ActionLink">
+<component-specification class="org.apache.tapestry.link.ActionLink" deprecated="true">
 
   <description>
   Creates a contextual link within the response page.  The page will be rewound to its
-  original state before the listener is invoked.
+  original state before the listener is invoked.  This component has been deprecated because
+  this approach is inherently unstable in the face of the changing server-side state.
   </description>
   
   <parameter name="listener" required="yes"/>

Modified: jakarta/tapestry/trunk/status.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=328674&r1=328673&r2=328674&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Wed Oct 26 09:55:39 2005
@@ -53,6 +53,7 @@
     <release version="4.0-beta-12" date="unreleased">
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-718">Asset injection makes assets appear as null inside finishLoad()</action>
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-580">Form, PageLink, DirectLink, etc. should support a scheme parameter for controlling the scheme of the generated URL</action>
+      <action type="update" dev="HLS">Deprecated the Action component and ActionService</action>
     </release>
     <release version="4.0-beta-11" date="Oct 16 2005">
       <action type="fix" dev="HLS" fixes-bug="TAPESTRY-650">ClassNotFoundException thrown when deserializing an object from a client persistent property</action>



---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org