You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "wjddn279 (via GitHub)" <gi...@apache.org> on 2026/05/03 08:52:13 UTC
[PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
wjddn279 opened a new pull request, #66303:
URL: https://github.com/apache/airflow/pull/66303
When `AIRFLOW__CORE__LOAD_EXAMPLES` is set to true (the default), example plugin loading triggers from `pandas.tseries.holiday import USFederalHolidayCalendar`, which retains an additional 66MB in memory.
This change switches to lazy loading so the module is imported only when scheduling calculations are actually performed.
<img width="1496" height="85" alt="image" src="https://github.com/user-attachments/assets/4a547d15-c8c5-486f-8d90-573c53b3e3e5" />
memray analysis in dag-processor when `AIRFLOW__CORE__LOAD_EXAMPLES` = true
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #66303:
URL: https://github.com/apache/airflow/pull/66303#discussion_r3179516530
##########
airflow-core/src/airflow/example_dags/plugins/workday.py:
##########
@@ -33,17 +33,24 @@
from airflow.timetables.base import TimeRestriction
log = logging.getLogger(__name__)
-try:
- from pandas.tseries.holiday import USFederalHolidayCalendar
-
- holiday_calendar = USFederalHolidayCalendar()
-except ImportError:
- log.warning("Could not import pandas. Holidays will not be considered.")
- holiday_calendar = None # type: ignore[assignment]
class AfterWorkdayTimetable(Timetable):
+ _holiday_calendar = None
Review Comment:
It’s not that big a deal in practice since the function is called essentially once every time the timetable is loaded in either case due to how Airflow works. But I agree having a way to distinguish between not-loaded and loading-failed is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #66303:
URL: https://github.com/apache/airflow/pull/66303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #66303:
URL: https://github.com/apache/airflow/pull/66303#issuecomment-4403878012
@uranusjr
Hello! could you merge this pr if you think no need more review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #66303:
URL: https://github.com/apache/airflow/pull/66303#discussion_r3178557360
##########
airflow-core/src/airflow/example_dags/plugins/workday.py:
##########
@@ -33,17 +33,24 @@
from airflow.timetables.base import TimeRestriction
log = logging.getLogger(__name__)
-try:
- from pandas.tseries.holiday import USFederalHolidayCalendar
-
- holiday_calendar = USFederalHolidayCalendar()
-except ImportError:
- log.warning("Could not import pandas. Holidays will not be considered.")
- holiday_calendar = None # type: ignore[assignment]
class AfterWorkdayTimetable(Timetable):
+ _holiday_calendar = None
Review Comment:
If pandas is not installed, the current logic will attempt to import and catch the `ImportError `every time `_get_holiday_calendar `is called because `_holiday_calendar `remains None.
Could we distinguish between not yet initialized and initialization failed? wdyt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load USFederalHolidayCalendar lazily to reduce memory usage when LOAD_EXAMPLES [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on code in PR #66303:
URL: https://github.com/apache/airflow/pull/66303#discussion_r3180055035
##########
airflow-core/src/airflow/example_dags/plugins/workday.py:
##########
@@ -33,17 +33,24 @@
from airflow.timetables.base import TimeRestriction
log = logging.getLogger(__name__)
-try:
- from pandas.tseries.holiday import USFederalHolidayCalendar
-
- holiday_calendar = USFederalHolidayCalendar()
-except ImportError:
- log.warning("Could not import pandas. Holidays will not be considered.")
- holiday_calendar = None # type: ignore[assignment]
class AfterWorkdayTimetable(Timetable):
+ _holiday_calendar = None
Review Comment:
Cool! thanks @henry3260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org