[jira] [Comment Edited] (FLUME-1993) On Windows, when using the spooling directory source, there is a file sharing violation when trying to delete tracker file

["Israel Ekpo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630841#comment-13630841 ] 

Israel Ekpo edited comment on FLUME-1993 at 4/13/13 1:04 AM:
-------------------------------------------------------------

Phil, in addition to the wiki link from Hari above, you can follow the steps below to create a review for the patch.

Check first to make sure that it follows the formatting guidelines and recommendations specified in the wiki page.

I will be updating the wiki page soon with these steps but in the time being, here are the steps for submitting the review for this patch:

(1) Get the latest code from GIT

git clone http://git-wip-us.apache.org/repos/asf/flume.git flume

cd flume

git checkout flume-1.4

The current branch for the next release is flume-1.4; this is why we are using "flume-1.4".

(2) Apply your changes to the code you have checked out

(3) Try to compile the code changes, create a tarball and run the unit tests to make sure that all is well with your changes

mvn clean install

It is very important to test the changes to make sure the work satisfactorily before submitting the patch

So you can configure the generated tarball and run it to see if it works for you first

(4) If all is well, then create the patches:

git diff --no-prefix > /path/to/FLUME-0011.patch

Use the JIRA issue ID for the patch files you generate.

If you have more than one pending patch (for different issues) to submit, you can specify the path to the file or directory where the changes are

For example:

git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/serialization/LineDeserializer.java > /path/to/FLUME-0001.patch

git diff --no-prefix flume-ng-doc/sphinx/Flume* > /path/to/FLUME-0002.patch

git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/sink/ > /path/to/FLUME-0003.patch

(5) Upload the patche file(s) to the JIRA issue and set the status to PATCH AVAILABLE.

(6) Create a review for your patch files here:

https://reviews.apache.org/

Pick "flume-git" as the repository and "Flume" as the group. The current branch is "flume-1.4"

(7) You can take a look at other code reviews here for some examples:

https://reviews.apache.org/groups/Flume/

Thank you for your contribution


                
      was (Author: iekpo):
    Phil, in addition to the wiki link from Hari above, you can follow the steps below to create a review for the patch.

Check first to make sure that it follows the formatting guidelines and recommendations specified in the wiki page.

I will be updating the wiki page soon with these steps but in the time being, here are the steps for submitting the review for this patch:

(1) Get the latest code from GIT

git clone http://git-wip-us.apache.org/repos/asf/flume.git flume

cd flume

git checkout flume-1.4

The current branch for the next release is flume-1.4; this is why we are using "flume-1.4".

(2) Apply your changes to the code you have checked out

(3) Try to compile the code changes, create a tarball and run the unit tests to make sure that all is well with your changes

mvn clean install

It is very important to test the changes to make sure the work satisfactorily before submitting the patch

So you can configure the generated tarball and run it to see if it works for you first

(4) If all is well, then create the patches:

git diff --no-prefix > /path/to/FLUME-0011.patch

Use the JIRA issue ID for the patch files you generate.

If you have more than one pending patch (for different issues) to submit, you can specific the path to the file or directory where the changes are

For example:

git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/serialization/LineDeserializer.java > /path/to/FLUME-0001.patch

git diff --no-prefix flume-ng-doc/sphinx/Flume* > /path/to/FLUME-0002.patch

git diff --no-prefix flume-ng-core/src/main/java/org/apache/flume/sink/ > /path/to/FLUME-0003.patch

(5) Upload the patche file(s) to the JIRA issue and set the status to PATCH AVAILABLE.

(6) Create a review for your patch files here:

https://reviews.apache.org/

Pick "flume-git" as the repository and "Flume" as the group. The current branch is "flume-1.4"

(7) You can take a look at other code reviews here for some examples:

https://reviews.apache.org/groups/Flume/



                  
> On Windows, when using the spooling directory source, there is a file sharing violation when trying to delete tracker file
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLUME-1993
>                 URL: https://issues.apache.org/jira/browse/FLUME-1993
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.4.0
>            Reporter: Phil Scala
>         Attachments: ReliableSpoolingFileEventReader.java, ReliableSpoolingFileEventReader.java.patch
>
>
> spooling directory source
> org.apache.flume.client.avro.ReliableSpoolingFileEventReader.getNextFile() 
> Gets an instance of a DurablePositionTracker and is not calling close() on it before then creating another instance... thus not calling close on the underlying DataFileWriter.  This left the file locked in Windows and hence any delete attempts were failing...causing the Agent to spin around and around trying to delete this file and creating endless numbers of the temporary tracker files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira