[GitHub] [pinot] shounakmk219 commented on a diff in pull request #10757: Improvements on the utility to convert table config to updated format

["shounakmk219 (via GitHub)" <gi...@apache.org>]

shounakmk219 commented on code in PR #10757:
URL: https://github.com/apache/pinot/pull/10757#discussion_r1191055185


##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/NullValueIndexTest.java:
##########
@@ -37,13 +35,7 @@ public void oldToNewConfConversion() {
       _tableConfig.getIndexingConfig().setNullHandlingEnabled(true);
       convertToUpdatedFormat();
       assertNotNull(_tableConfig.getFieldConfigList());

Review Comment:
   Makes sense, will add the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org