You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2006/09/28 22:43:07 UTC
Versions in (was: Re: svn commit: r451020 - /geronimo/server/trunk/pom.xml)
Hi,
This commit log shows that we need versions to be kept as properties
in <properties> section of Geronimo pom. On the other hand, I'm pretty
sure that Jason, Anita, Prasad or others who've been working on the M2
build have already spot it and there must be some obvious reasons it
is not done this way. What are they? Why don't we use <properties> to
avoid repeating versions?
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
On 9/28/06, djencks@apache.org <dj...@apache.org> wrote:
> Author: djencks
> Date: Thu Sep 28 13:27:27 2006
> New Revision: 451020
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=451020
> Log:
> GERONIMO-2445 get incubator into the version
>
> Modified:
> geronimo/server/trunk/pom.xml
>
> Modified: geronimo/server/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?view=diff&rev=451020&r1=451019&r2=451020
> ==============================================================================
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Thu Sep 28 13:27:27 2006
> @@ -561,19 +561,19 @@
> <dependency>
> <groupId>org.apache.openejb</groupId>
> <artifactId>openejb-core</artifactId>
> - <version>2.2-SNAPSHOT</version>
> + <version>2.2-incubating-SNAPSHOT</version>
> </dependency>
>
> <dependency>
> <groupId>org.apache.openejb</groupId>
> <artifactId>openejb-builder</artifactId>
> - <version>2.2-SNAPSHOT</version>
> + <version>2.2-incubating-SNAPSHOT</version>
> </dependency>
>
> <dependency>
> <groupId>org.apache.openejb</groupId>
> <artifactId>openejb-pkgen-builder</artifactId>
> - <version>2.2-SNAPSHOT</version>
> + <version>2.2-incubating-SNAPSHOT</version>
> </dependency>
>
> <dependency>
>
>
>
Re: Versions in (was: Re: svn commit: r451020 - /geronimo/server/trunk/pom.xml)
Posted by Jason Dillon <ja...@planet57.com>.
It is easier to comprehend the 3 repeated versions next to each
other, than it is to manage a set of properties which are defined
elsewhere.
If properties could be defined inline with dependency's in a
dependencyManagement section, then it would be fine. But with out
that, we end up with a huge list of properties and a huge list of
dependencies, and then to see what version is what, you have to keep
bouncing back and forth.
The properties also tend to promote people using them in child poms,
instead of adding a dependency to the dependencyManagement section
and omitting the version in the child as they should do.
--jason
On Sep 28, 2006, at 1:43 PM, Jacek Laskowski wrote:
> Hi,
>
> This commit log shows that we need versions to be kept as properties
> in <properties> section of Geronimo pom. On the other hand, I'm pretty
> sure that Jason, Anita, Prasad or others who've been working on the M2
> build have already spot it and there must be some obvious reasons it
> is not done this way. What are they? Why don't we use <properties> to
> avoid repeating versions?
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
>
> On 9/28/06, djencks@apache.org <dj...@apache.org> wrote:
>> Author: djencks
>> Date: Thu Sep 28 13:27:27 2006
>> New Revision: 451020
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=451020
>> Log:
>> GERONIMO-2445 get incubator into the version
>>
>> Modified:
>> geronimo/server/trunk/pom.xml
>>
>> Modified: geronimo/server/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?
>> view=diff&rev=451020&r1=451019&r2=451020
>> =====================================================================
>> =========
>> --- geronimo/server/trunk/pom.xml (original)
>> +++ geronimo/server/trunk/pom.xml Thu Sep 28 13:27:27 2006
>> @@ -561,19 +561,19 @@
>> <dependency>
>> <groupId>org.apache.openejb</groupId>
>> <artifactId>openejb-core</artifactId>
>> - <version>2.2-SNAPSHOT</version>
>> + <version>2.2-incubating-SNAPSHOT</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.apache.openejb</groupId>
>> <artifactId>openejb-builder</artifactId>
>> - <version>2.2-SNAPSHOT</version>
>> + <version>2.2-incubating-SNAPSHOT</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.apache.openejb</groupId>
>> <artifactId>openejb-pkgen-builder</artifactId>
>> - <version>2.2-SNAPSHOT</version>
>> + <version>2.2-incubating-SNAPSHOT</version>
>> </dependency>
>>
>> <dependency>
>>
>>
>>